Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Maker: Setup page improvements and initialization cleanup #13286
Takes advantage of the stateless board reset introduced in #13252 to remove some now-dead code and allow re-detect on the setup page without a page reload. Also made some cosmetic changes to the setup page 'detect' sequence that make it feel more reliable.
1. The re-detect button no longer triggers a setup page reload, because we're now able to initialize from scratch multiple times on a page. 2. Re-detect is disabled during board detection, to avoid any confusion. 3. I've introduced some artifical delay into the setup steps - it's more reassuring and satisfying to see each step spin for a moment before turning green, than to have most steps succeed instantaneously. 4. Issues with dropped serialport traffic meant we sometimes didn't manage to enable or disable all the LEDs at once on successful connection. I've made success animate the LEDs in sequence instead, which is not only more dynamic and interesting, it seems to be much more reliable. We'll address general issues with dropped messages soon, but for now making the setup page seem more reliable will help.