Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix design mode in App Lab for Chrome 64 #21082

Merged
merged 1 commit into from Mar 7, 2018
Merged

Conversation

@islemaster
Copy link
Member

islemaster commented Mar 7, 2018

Removes the browserSupportsCssMedia() check which only existed for IE9 compatibility and was causing a CORS issue for some users on Chrome 64 because we iterate through all loaded stylesheets, which may include external stylesheets injected by plugins.

I've posted a detailed problem description to StackOverflow in case it's useful to other developers.

Copy link
Contributor

davidsbailey left a comment

yay removing dead code! (or worse than dead)

@islemaster islemaster merged commit c226312 into staging Mar 7, 2018
2 checks passed
2 checks passed
DTS The staging branch is open.
ci/circleci Your tests passed on CircleCI!
Details
@islemaster islemaster deleted the remove-stylesheet-query branch Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.