Specify that TestCase transaction should not be lazy #38531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to rails/rails#35082, Rails transactions were at some point made lazy, which started causing problems for test transactions. When trying to upgrade to Rail 6, we saw similar problems with our custom implementation of transactions for test _cases_ rather than just individual tests. Mirroring the fixes in the linked PR in our own implementation seems to work.
Hamms
changed the title
Hamms
added
the
Rails Upgrade
wjordan
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to rails/rails#35082, Rails transactions were at some point made lazy, which started causing problems for test transactions.
When trying to upgrade to Rail 6, we saw similar problems with our custom implementation of transactions for test cases rather than just individual tests. Mirroring the fixes in the linked PR in our own implementation seems to resolve those problems.
Testing story
N/A
Links
Reviewer Checklist: