Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
React Wrapper Step 2: Break RotateContainer and cleardiv out of EJS #7026
Start removing content from page.html.ejs.
TODO before merge:
Step 2 from this design document.
Okay, pretty confident
(If dashboard was setting
The latter step has actually duplicated knowledge of whether to require landscape mode across the different apps. I'm not sure where to deduplicate it again.
Thoughts? I'm learning toward option 2 right now, but not sure any are worth doing yet - it's possible the next step (splitting page.html.ejs) will bring more clarity to this discussion.