Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
React Wrapper Step 3: Split page.html.ejs along column divide #7051
Splits the page.html.ejs template into two files, one for the contents of
This has several side effects:
Step 3 from this design document.
Worst bug surface in this change is probably from typos in breaking out the properties passed to the EJS rendering functions.
Now in two parts: - visualizationColumn.html.ejs - codeWorkspace.html.ejs Each app has its own version of rendering these two templates, hence we need to touch each app's init() function again. Once again this is more verbose for now, but the separation of concerns should lead us toward less duplication in the end. Ran UI tests locally.
Grabs common code from NetSimView and AppView and creates a component they both use, while letting them stay as separate top-level components.
Changes ProtectedStatefulDiv to no longer require a renderContents function. It also now passes _all_ of its props (via JSX spread attributes) to its root DOMComponent. Together, this makes it easy to define an empty div with an id and some classes or style attributes, that should never be updated by React - like our resize bar, for example.
48ea6d2 Merge pull request #7051 from code-dot-org/react-wrapper-split-page-ejs (Brad Buchanan) a373081 Indent 'if' blocks in new ejs files (Brad Buchanan) 93fd1bb Merge pull request #7055 from code-dot-org/selenim-selenium-1 (Ram Kandasamy) 9dde82a Automatically built. (Continuous Integration) 6994751 Fix typo: Selenim -> Selenium (Ram Kandasamy) 48ce748 Merge pull request #7050 from code-dot-org/copyrightSize (Brent Van Minnen) b5bf638 Render resize bar as a ProtectedStatefulDiv (Brad Buchanan) 73b648a Automatically built. (Continuous Integration)