Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key control option #15

Merged
merged 8 commits into from Oct 7, 2019

Conversation

@brendonofficial
Copy link
Contributor

commented Oct 4, 2019

This PR introduces the functionality to control the accessibility to get or set specific keys by passing in a class that implements the AccessibilityInterface interface in to the constructor of the DoctrineEntityConfig, or DoctrineConfig repositories.

This PR includes test coverage and improved Exception classes, as well as updated to the README to provide an usage example for the interface.

This PR includes:

  • Addition of .gitignore and composer.lock
  • Creation of the AccessibilityInterface interface, and NullAccessibility class
  • Updates to tests
  • Improved Exception classes
  • Some code clean up
  • Update to the README
…ons, created base exception for other exceptions to extend, created accessibility interface and null accessibility class, some code cleanup
… new and existing classes, added code coverage ignore to DoctrineEntityManagerBuilder
Copy link
Contributor

left a comment

Really like this work, couple of things I'd like to change.

…l', added 'entity' argument to check methods, updated tests
@edward-murrell

This comment has been minimized.

Copy link
Contributor

commented Oct 7, 2019

Also fixes issues #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.