Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Empty fields when uploading records with new attributes #144

Closed
SirDegraf opened this issue Oct 13, 2022 · 2 comments
Closed

[BUG] - Empty fields when uploading records with new attributes #144

SirDegraf opened this issue Oct 13, 2022 · 2 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@SirDegraf
Copy link
Contributor

Describe the bug
If a record gets uploaded into an existing project with records in it with a new attribute (which is not yet present in the project) it gets created and all of the other records get an empty attribute field added in the data browser. They are most certainly not added into the database (not 100% sure) but the data browsers appearance can make it seem like empty field were added.

To Reproduce
Steps to reproduce the behavior:
It can be reproduced by creating a sample Clickbait project and then upload the dataset "clickbait_abc_extension_1.json" out of the referenced test-sets.zip/1 into the clickbait project.

Expected behavior
I don't really know what the best solution is here but i think the way it is at the moment could confuse many users. Maybe display that these empty attributes are not really existent for the record, but like i said, a solution is still to be thought of.

Screenshots
image

Desktop (please complete the following information):

  • OS: macOS
  • Browser chrome
@SirDegraf SirDegraf added bug Something isn't working enhancement New feature or request labels Oct 13, 2022
@JWittmeyer
Copy link
Member

imo a marker "not present in record" would be easy to include and help with the confusion :)

@lumburovskalina
Copy link
Contributor

Steps to fix bug:

  1. Upload the additional record to reproduce bug. (15minutes)
  2. Set condition in the data-browser and labeling page when the attribute is not present (30minutes)
  3. If the condition is true, set a marker (maybe a warning icon)? (15minutes)
  4. Testing and review (1h)

Estimation time: 2h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants