New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to webpack v4 #57

Merged
merged 6 commits into from Oct 15, 2018

Conversation

Projects
None yet
2 participants
@gokulkrishh
Copy link
Member

gokulkrishh commented Oct 15, 2018

What's done:

  • Added prettier, pre-commit stage.
  • Moved from webpack v2 to v4.
  • Updated few file names.
  • Added netlify demo for each PR.
  • Added DangerJS & Travis.
@gokulkrishh

This comment has been minimized.

Copy link
Member Author

gokulkrishh commented Oct 15, 2018

Deploy preview for qrcode-4951b7 ready!

Built with commit 1888e40

https://deploy-preview-57--qrcode-4951b7.netlify.com

@gokulkrishh gokulkrishh changed the title Gk upgraded to webpack v4 Upgraded to webpack v4 Oct 15, 2018

@gokulkrishh gokulkrishh force-pushed the gk-upgraded-to-webpack-v4 branch from daf84bd to 09f8052 Oct 15, 2018

@code-kotis-bot

This comment has been minimized.

Copy link

code-kotis-bot commented Oct 15, 2018

Warnings
⚠️

asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
This can impact web performance.
Assets:
decoder.js (3.38 MiB),webpack performance recommendations:
You can limit the size of your bundles by using import() or require.ensure to lazy load some parts of your application.
For more info visit https://webpack.js.org/guides/code-splitting/

Messages
📖

🎉 The PR added 209908 and removed 49708 lines.

📖

Changed Files in this PR:

  • .gitignore
  • README.md
  • app/css/styles.css
  • app/index.html
  • app/js/main.js
  • app/js/snackbar.js
  • app/js/vendor/qrscan.js
  • package.json
  • webpack.config.js
  • yarn.lock

Generated by 🚫 dangerJS

gokulkrishh added some commits Oct 15, 2018

@gokulkrishh gokulkrishh merged commit 9a68f93 into master Oct 15, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (hemanth) No new issues
Details

@gokulkrishh gokulkrishh deleted the gk-upgraded-to-webpack-v4 branch Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment