New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#203 Switch from brunch to webpack #250

Merged
merged 8 commits into from Sep 25, 2018

Conversation

Projects
None yet
2 participants
@Atul9
Contributor

Atul9 commented Sep 19, 2018

closes #203

Switch from brunch to webpack
Signed-off-by: Atul Bhosale <atul1bhosale@gmail.com>

@Atul9 Atul9 requested a review from emilsoman Sep 19, 2018

@HarshwardhanSingh

@Atul9 left some comments and some questions.

Show outdated Hide outdated apps/dockup_ui/assets/.babelrc Outdated
Show outdated Hide outdated apps/dockup_ui/assets/js/socket.js Outdated
Show outdated Hide outdated apps/dockup_ui/assets/js/socket.js Outdated
Show outdated Hide outdated apps/dockup_ui/assets/package.json Outdated
Show outdated Hide outdated apps/dockup_ui/assets/webpack.config.js Outdated
Show outdated Hide outdated apps/dockup_ui/assets/webpack.config.js Outdated
Show outdated Hide outdated apps/dockup_ui/assets/webpack.config.js Outdated
Show outdated Hide outdated apps/dockup_ui/assets/webpack.config.js Outdated

@Atul9 Atul9 self-assigned this Sep 24, 2018

@HarshwardhanSingh

@Atul9 Please test if the build is working fine. Everything looks fine. 👍

@Atul9

This comment has been minimized.

Show comment
Hide comment
@Atul9

Atul9 Sep 25, 2018

Contributor

@HarshwardhanSingh I have run this branch locally and it works fine. Can you merge this PR?

Contributor

Atul9 commented Sep 25, 2018

@HarshwardhanSingh I have run this branch locally and it works fine. Can you merge this PR?

@HarshwardhanSingh HarshwardhanSingh merged commit 9b9c91f into k8s-ui Sep 25, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@HarshwardhanSingh HarshwardhanSingh deleted the phoenix-webpack branch Sep 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment