From 2728a205eb3c569f2c27b2aaeca4cb96ea94e9e9 Mon Sep 17 00:00:00 2001 From: Michael Hladky Date: Tue, 2 Sep 2025 03:00:51 +0200 Subject: [PATCH 1/4] chore: adjust code-pushup-coverage target --- code-pushup.preset.ts | 7 ------- project.json | 4 +++- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/code-pushup.preset.ts b/code-pushup.preset.ts index 58ae48c4e..bc06011d5 100644 --- a/code-pushup.preset.ts +++ b/code-pushup.preset.ts @@ -193,16 +193,9 @@ export const coverageCoreConfigNx = async ( projectName?: string, ): Promise => { const targetNames = ['unit-test', 'int-test']; - const targetArgs = ['-t', ...targetNames]; return { plugins: [ await coveragePlugin({ - coverageToolCommand: { - command: 'npx', - args: projectName - ? ['nx', 'run-many', '-p', projectName, ...targetArgs] - : ['nx', 'run-many', ...targetArgs], - }, reports: projectName ? [ { diff --git a/project.json b/project.json index aa58578bd..ac255666e 100644 --- a/project.json +++ b/project.json @@ -4,7 +4,9 @@ "targets": { "code-pushup-js-packages": {}, "code-pushup-lighthouse": {}, - "code-pushup-coverage": {}, + "code-pushup-coverage": { + "dependsOn": ["^*-test"] + }, "code-pushup-eslint": {}, "code-pushup-jsdocs": {}, "code-pushup-typescript": {}, From 6659a6c9db13232c071bfad717bbd45d49e53f5d Mon Sep 17 00:00:00 2001 From: Michael Hladky Date: Tue, 2 Sep 2025 14:14:08 +0200 Subject: [PATCH 2/4] refactor: adjust targets --- project.json | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/project.json b/project.json index ac255666e..c311f96fb 100644 --- a/project.json +++ b/project.json @@ -5,7 +5,12 @@ "code-pushup-js-packages": {}, "code-pushup-lighthouse": {}, "code-pushup-coverage": { - "dependsOn": ["^*-test"] + "dependsOn": [ + { + "target": "^*-test", + "projects": "*" + } + ] }, "code-pushup-eslint": {}, "code-pushup-jsdocs": {}, From 4df328d7b1aae7bf5484698313b65aa11acebde3 Mon Sep 17 00:00:00 2001 From: Michael Hladky Date: Tue, 2 Sep 2025 14:14:36 +0200 Subject: [PATCH 3/4] refactor: adjust targets 2 --- project.json | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/project.json b/project.json index c311f96fb..fc7dfea0d 100644 --- a/project.json +++ b/project.json @@ -7,7 +7,11 @@ "code-pushup-coverage": { "dependsOn": [ { - "target": "^*-test", + "target": "unit-test", + "projects": "*" + }, + { + "target": "int-test", "projects": "*" } ] From 85ec45fce0522a16b9c09b6290f047b0cbadbe5a Mon Sep 17 00:00:00 2001 From: Michael Hladky Date: Tue, 2 Sep 2025 14:24:35 +0200 Subject: [PATCH 4/4] refactor: add comments --- code-pushup.preset.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/code-pushup.preset.ts b/code-pushup.preset.ts index bc06011d5..5d9200904 100644 --- a/code-pushup.preset.ts +++ b/code-pushup.preset.ts @@ -196,6 +196,7 @@ export const coverageCoreConfigNx = async ( return { plugins: [ await coveragePlugin({ + // We do not need to run a coverageToolCommand. This is handled over the Nx task graph. reports: projectName ? [ {