-
Notifications
You must be signed in to change notification settings - Fork 15
ci: run code-pushup on self in monorepo mode #1154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
View your CI Pipeline Execution ↗ for commit a61f991
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/axe-plugin
@code-pushup/nx-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
@code-pushup/models-transformers
commit: |
fa86807 to
f90a4e4
Compare
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit df4cd75 with previous commit d21a99c. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 4 groups regressed, 👍 5 audits improved, 👎 9 audits regressed, 16 audits changed without impacting score🗃️ Groups
18 other groups are unchanged. 🛡️ Audits
648 other audits are unchanged. |
f90a4e4 to
b47aa6a
Compare
BioPhoton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice dogfooding! I had a question for custom target names.
BioPhoton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related to #888 ... sort of. I want to be able to evaluate our CI logs in a representative environment, which requires completing what @BioPhoton started in #1062.
I split our Code PushUp workflow into 2 distinct jobs:
print-configcommands by providingconfigPatternsEach job posts separate PR comments (I added a special
jobIdto@code-pushup/cifor this use case).I refactored the
code-pushup.preset.tsfile to minimize duplication incode-pushup.config.tsfiles.