Remove logging.Fatal from machine start #1066
Comments
anjannath
added a commit
to anjannath/crc
that referenced
this issue
Mar 5, 2020
In case of the daemon, we don't want an error in machine.Start() to exit the daemon process, logging.Fatal calls os.Exit which kills the process
anjannath
added a commit
to anjannath/crc
that referenced
this issue
Mar 5, 2020
In case of the daemon, we don't want an error in machine.Start() to exit the daemon process, logging.Fatal calls os.Exit which kills the process
anjannath
added a commit
to anjannath/crc
that referenced
this issue
Mar 5, 2020
In case of the daemon, we don't want an error in machine.Start() to exit the daemon process, logging.Fatal calls os.Exit which kills the process
anjannath
added a commit
to anjannath/crc
that referenced
this issue
Mar 5, 2020
In case of the daemon, we don't want an error in machine.Start() to exit the daemon process, logging.Fatal calls os.Exit which kills the process
anjannath
added a commit
to anjannath/crc
that referenced
this issue
Mar 5, 2020
In case of the daemon, we don't want an error in machine.Start() to exit the daemon process, logging.Fatal calls os.Exit which kills the process
praveenkumar
pushed a commit
that referenced
this issue
Mar 5, 2020
In case of the daemon, we don't want an error in machine.Start() to exit the daemon process, logging.Fatal calls os.Exit which kills the process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When a crc vm with a different bundle versions exists, we error out calling logging.Fatal which calls os.Exit() and makes the whole process exit, which is bad for the daemon.
https://github.com/code-ready/crc/blob/3ba6f260e5276c814077706fde0789bc238ecfbf/pkg/crc/machine/machine.go#L187-L190
The text was updated successfully, but these errors were encountered: