Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn user in advance about possible cert expiration #477

Closed
praveenkumar opened this issue Aug 27, 2019 · 6 comments

Comments

@praveenkumar
Copy link
Contributor

commented Aug 27, 2019

We should add a warn message just after the VM creation if the cert of the VM is going to expired soon (assume only 10 days left), Right now we have check which tell user if the cert is already expired but at that time user now have an unusable VM and his workload might be there, putting a fair warning before hand should be good from crc prospective.

@gbraad

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

Not sure how you see this check to happen. We have to check inside the VM to determine this... or you want to base this of the bundle creation time?

@praveenkumar

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

@gbraad The check we have inside VM to determine actually error out when the cert is expired we just need to extend this check to warn a user if cert is going to expire within 7-10 days.

@gbraad

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

I would also go so far to record this certificate time as a precaution inside a data file alongside the VM. This way we can report to the user without having to start the VM, as this process can take quite some time (as warning). It will never be a perfect solution, so the final message comes from the actual VM having started.

@gbraad gbraad changed the title Warn user before the VM cert is expired. Warn user in advance about possible cert expiration Aug 28, 2019
@praveenkumar

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

@gbraad what we can do is to use the metadata json info about buildtime we have.

"buildInfo": {
    "buildTime": "2019-08-23T18:08:27+00:00",

So if a user start for fresh then we use this to show the warning and if a user going to run from a stopped then we should use from the VM to show that warning.

@gbraad

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

This ties in with: #484 since expiration needs to allow for update.

praveenkumar added a commit to praveenkumar/crc that referenced this issue Sep 5, 2019
If a user start VM from a clean state then check the bundle build
time and warn user about cert expiry. If user start a stopped VM
then from the VM check the validation of cert and warn the user.
praveenkumar added a commit to praveenkumar/crc that referenced this issue Sep 5, 2019
…ays.

If a user start VM from a clean state then check the bundle build
time and warn user about cert expiry. If user start a stopped VM
then from the VM check the validation of cert and warn the user.
praveenkumar added a commit to praveenkumar/crc that referenced this issue Sep 5, 2019
…ays.

If a user start VM from a clean state then check the bundle build
time and warn user about cert expiry. If user start a stopped VM
then from the VM check the validation of cert and warn the user.
praveenkumar added a commit to praveenkumar/crc that referenced this issue Sep 6, 2019
…ays.

If a user start VM from a clean state then check the bundle build
time and warn user about cert expiry. If user start a stopped VM
then from the VM check the validation of cert and warn the user.
praveenkumar added a commit that referenced this issue Sep 9, 2019
If a user start VM from a clean state then check the bundle build
time and warn user about cert expiry. If user start a stopped VM
then from the VM check the validation of cert and warn the user.
@cfergeau

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2019

Fixed by the commits above.

@cfergeau cfergeau closed this Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.