Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'BeforeFeature' errors are ignored by integration checks #640

Closed
cfergeau opened this issue Sep 25, 2019 · 0 comments
Closed

'BeforeFeature' errors are ignored by integration checks #640

cfergeau opened this issue Sep 25, 2019 · 0 comments

Comments

@cfergeau
Copy link
Contributor

I was passing relative paths as BUNDLE_LOCATION and PULL_SECRET_FILE, it took me a while to figure out why the tests were failing.

cfergeau added a commit to cfergeau/crc that referenced this issue Sep 25, 2019
cfergeau added a commit to cfergeau/crc that referenced this issue Sep 25, 2019
…eFeature

fmt.Errorf creates a new 'error' instance, but does not have any
user-visible side effects. This commit adds better reporting of errors
(missing bundle) by printing the message, and exiting the test process
when there are failures in the BeforeFeature steps.

This fixes crc-org#640
praveenkumar pushed a commit that referenced this issue Sep 27, 2019
It was missing PULL_SECRET_FILE.

#640
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant