From 895135bad6a607619255571f2459acee7d138dc6 Mon Sep 17 00:00:00 2001 From: Pedro Almeida Date: Mon, 8 Jun 2026 20:58:16 -0300 Subject: [PATCH] Improved type safety in edit recommendation modal (#26124) no ref This PR is a small code quality improvement without an associated issue. --- .../growth/recommendations/edit-recommendation-modal.tsx | 2 +- .../recommendations/recommendation-description-form.tsx | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/apps/admin-x-settings/src/components/settings/growth/recommendations/edit-recommendation-modal.tsx b/apps/admin-x-settings/src/components/settings/growth/recommendations/edit-recommendation-modal.tsx index a5e0d133e2c..3ba937816a0 100644 --- a/apps/admin-x-settings/src/components/settings/growth/recommendations/edit-recommendation-modal.tsx +++ b/apps/admin-x-settings/src/components/settings/growth/recommendations/edit-recommendation-modal.tsx @@ -93,7 +93,7 @@ const EditRecommendationModal: React.FC - + ; }; diff --git a/apps/admin-x-settings/src/components/settings/growth/recommendations/recommendation-description-form.tsx b/apps/admin-x-settings/src/components/settings/growth/recommendations/recommendation-description-form.tsx index 5ea43ffa6be..2a2d4cd3553 100644 --- a/apps/admin-x-settings/src/components/settings/growth/recommendations/recommendation-description-form.tsx +++ b/apps/admin-x-settings/src/components/settings/growth/recommendations/recommendation-description-form.tsx @@ -1,6 +1,6 @@ import React from 'react'; import RecommendationIcon from './recommendation-icon'; -import {type EditOrAddRecommendation, type Recommendation} from '@tryghost/admin-x-framework/api/recommendations'; +import {type EditOrAddRecommendation} from '@tryghost/admin-x-framework/api/recommendations'; import {type ErrorMessages} from '@tryghost/admin-x-framework/hooks'; import {Form, Heading, Hint, TextArea, TextField, URLTextField} from '@tryghost/admin-x-design-system'; @@ -45,7 +45,7 @@ export const validateDescriptionForm = function (formState: EditOrAddRecommendat return newErrors; }; -const RecommendationDescriptionForm: React.FC> = ({showURL, formState, updateForm, errors, clearError, setErrors}) => { +function RecommendationDescriptionForm({showURL, formState, updateForm, errors, clearError, setErrors}: Props) { const [descriptionLength, setDescriptionLength] = React.useState(formState?.description?.length || 0); const descriptionLengthColor = descriptionLength > 200 ? 'text-red' : 'text-green'; @@ -122,6 +122,6 @@ const RecommendationDescriptionForm: React.FC ; -}; +} export default RecommendationDescriptionForm;