Skip to content

[pull] main from TryGhost:main #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 1 commit into from
Jun 9, 2026
+4 −4
Merged

[pull] main from TryGhost:main #1222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...n-x-settings/src/components/settings/growth/recommendations/edit-recommendation-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ const EditRecommendationModal: React.FC<RoutingModalProps & EditRecommendationMo
}
}}
>
<RecommendationDescriptionForm clearError={clearError} errors={errors} formState={formState} setErrors={setErrors} showURL={true} updateForm={updateForm as any}/>
<RecommendationDescriptionForm clearError={clearError} errors={errors} formState={formState} setErrors={setErrors} showURL={true} updateForm={updateForm}/>
</Modal>;
};

Expand Down
6 changes: 3 additions & 3 deletions ...ttings/src/components/settings/growth/recommendations/recommendation-description-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from 'react';
import RecommendationIcon from './recommendation-icon';
import {type EditOrAddRecommendation, type Recommendation} from '@tryghost/admin-x-framework/api/recommendations';
import {type EditOrAddRecommendation} from '@tryghost/admin-x-framework/api/recommendations';
import {type ErrorMessages} from '@tryghost/admin-x-framework/hooks';
import {Form, Heading, Hint, TextArea, TextField, URLTextField} from '@tryghost/admin-x-design-system';

Expand Down Expand Up @@ -45,7 +45,7 @@ export const validateDescriptionForm = function (formState: EditOrAddRecommendat
return newErrors;
};

const RecommendationDescriptionForm: React.FC<Props<EditOrAddRecommendation | Recommendation>> = ({showURL, formState, updateForm, errors, clearError, setErrors}) => {
function RecommendationDescriptionForm<T extends EditOrAddRecommendation>({showURL, formState, updateForm, errors, clearError, setErrors}: Props<T>) {
const [descriptionLength, setDescriptionLength] = React.useState(formState?.description?.length || 0);
const descriptionLengthColor = descriptionLength > 200 ? 'text-red' : 'text-green';

Expand Down Expand Up @@ -122,6 +122,6 @@ const RecommendationDescriptionForm: React.FC<Props<EditOrAddRecommendation | Re
}}
/>
</Form>;
};
}

export default RecommendationDescriptionForm;
Loading