From 594fb5e9abea8aee20dec5e0dfba39dac16ce53f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Markb=C3=A5ge?= Date: Mon, 11 Aug 2025 01:50:26 -0400 Subject: [PATCH] [DevTools] Always skip 1 frame (#34167) Follow up to #34093. There's an issue where the skipFrames argument isn't part of the cache key so the other parsers that expect skipping one frame might skip zero and show the internal `fakeJSXDEV` callsite. Ideally we should include the skipFrames as part of the cache key but we can also always just skip one. --- .../react-devtools-shared/src/backend/utils/parseStackTrace.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-devtools-shared/src/backend/utils/parseStackTrace.js b/packages/react-devtools-shared/src/backend/utils/parseStackTrace.js index 92b4156de7fa1..335fe42709193 100644 --- a/packages/react-devtools-shared/src/backend/utils/parseStackTrace.js +++ b/packages/react-devtools-shared/src/backend/utils/parseStackTrace.js @@ -284,7 +284,7 @@ export function parseStackTrace( export function extractLocationFromOwnerStack( error: Error, ): ReactFunctionLocation | null { - const stackTrace = parseStackTrace(error, 0); + const stackTrace = parseStackTrace(error, 1); const stack = error.stack; if ( !stack.includes('react_stack_bottom_frame') &&