From b2529831f6b80f339774a71b0515a6b7dc50a985 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Filipe=20Caba=C3=A7o?= Date: Mon, 25 Aug 2025 23:18:08 +0100 Subject: [PATCH 1/2] realtime: remove broadcast from footer (#38187) the tests we were running were a success and we no longer require to broadcast. we will keep the logic as we might want to dog food other ideas in the near future --- apps/www/components/Footer/index.tsx | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/apps/www/components/Footer/index.tsx b/apps/www/components/Footer/index.tsx index 21d5241eab2d6..d4c64ebc02150 100644 --- a/apps/www/components/Footer/index.tsx +++ b/apps/www/components/Footer/index.tsx @@ -29,15 +29,7 @@ const Footer = (props: Props) => { useEffect(() => { const channel = supabase.channel('footer') if (channel.state === REALTIME_CHANNEL_STATES.closed) { - channel.subscribe((status: string) => { - if (status == 'SUBSCRIBED') { - channel.send({ - type: 'broadcast', - event: 'footer_subscribed', - payload: { ts: Date.now() }, - }) - } - }) + channel.subscribe() } return () => { channel.unsubscribe() From b59b002764d0e70a30ee88350ad9e2be3b7a450c Mon Sep 17 00:00:00 2001 From: Joshen Lim Date: Tue, 26 Aug 2025 10:49:57 +0800 Subject: [PATCH 2/2] www nav CTAs to only render after user is loaded (#38177) --- apps/www/components/Nav/index.tsx | 93 ++++++++++++++++--------------- 1 file changed, 49 insertions(+), 44 deletions(-) diff --git a/apps/www/components/Nav/index.tsx b/apps/www/components/Nav/index.tsx index 3313dd542be59..5465669ad40aa 100644 --- a/apps/www/components/Nav/index.tsx +++ b/apps/www/components/Nav/index.tsx @@ -3,8 +3,9 @@ import { useRouter } from 'next/router' import React, { useState } from 'react' import { useWindowSize } from 'react-use' -import { useIsLoggedIn, useUser } from 'common' +import { useIsLoggedIn, useIsUserLoading, useUser } from 'common' import { Button, buttonVariants, cn } from 'ui' +import { AuthenticatedDropdownMenu } from 'ui-patterns' import { NavigationMenu, NavigationMenuContent, @@ -13,15 +14,14 @@ import { NavigationMenuList, NavigationMenuTrigger, } from 'ui/src/components/shadcn/ui/navigation-menu' -import { AuthenticatedDropdownMenu } from 'ui-patterns' import ScrollProgress from 'components/ScrollProgress' +import { useSendTelemetryEvent } from 'lib/telemetry' import GitHubButton from './GitHubButton' import HamburgerButton from './HamburgerMenu' import MenuItem from './MenuItem' import MobileMenu from './MobileMenu' import RightClickBrandLogo from './RightClickBrandLogo' -import { useSendTelemetryEvent } from 'lib/telemetry' import useDropdownMenu from './useDropdownMenu' import { getMenu } from 'data/nav' @@ -35,12 +35,15 @@ const Nav = ({ hideNavbar, stickyNavbar = true }: Props) => { const router = useRouter() const { width } = useWindowSize() const [open, setOpen] = useState(false) - const isLoggedIn = useIsLoggedIn() const menu = getMenu() const sendTelemetryEvent = useSendTelemetryEvent() const user = useUser() const userMenu = useDropdownMenu(user) + const isLoggedIn = useIsLoggedIn() + const isLoadingUser = useIsUserLoading() + console.log({ isLoadingUser, isLoggedIn }) + const isLaunchWeekPage = router.pathname.includes('/launch-week') const isLaunchWeekXPage = router.pathname === '/launch-week/x' const isGAWeekSection = router.pathname.startsWith('/ga-week') @@ -126,47 +129,49 @@ const Nav = ({ hideNavbar, stickyNavbar = true }: Props) => { -
- + {!isLoadingUser && ( +
+ - {isLoggedIn ? ( - <> - - - - ) : ( - <> - - - - )} -
+ {isLoggedIn ? ( + <> + + + + ) : ( + <> + + + + )} +
+ )} setOpen(true)}