Add visual testing #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/base-ui/-/pipelines/1111307584 Status: Passed Job summariesstorybook:buildStorybook available at https://code0-tech.gitlab.io/-/base-ui/-/jobs/5775896137/artifacts/storybook-static/index.html |
Taucher2003
force-pushed
the
visual-tests
branch
from
aaeb329 to
9ba20b1
Compare
|
@nicosammito what do you think? Should we add visual testing here, so the pipeline fails if a story looks different than what is expected? |
Yeh that sounds like a rly good idea 👍🏻 |
Taucher2003
force-pushed
the
visual-tests
branch
from
9ba20b1 to
a7dac8d
Compare
Taucher2003
force-pushed
the
visual-tests
branch
from
a7dac8d to
17b87d8
Compare
Taucher2003
force-pushed
the
visual-tests
branch
2 times, most recently
from
67a722e to
2a70780
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.