From ee7494d8011d6d9192a6d76cd8d741612f545696 Mon Sep 17 00:00:00 2001 From: nicosammito Date: Sun, 18 Feb 2024 21:25:19 +0100 Subject: [PATCH 1/5] added offset 8 = 0.5rem --- src/components/popover/InternalPopover.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/popover/InternalPopover.tsx b/src/components/popover/InternalPopover.tsx index 9e784e6a..53763620 100644 --- a/src/components/popover/InternalPopover.tsx +++ b/src/components/popover/InternalPopover.tsx @@ -10,7 +10,7 @@ interface InternalPopoverType extends Omit { export const InternalPopover: React.FC = (props) => { - const {children, state, offset = 0, ...args} = props + const {children, state, offset = 8, ...args} = props const popoverRef = React.useRef(null); const {popoverProps} = usePopover({ ...args, From d4a72d7757e929204bbd93e8cbd28a1c0361992f Mon Sep 17 00:00:00 2001 From: nicosammito Date: Sun, 18 Feb 2024 21:25:45 +0100 Subject: [PATCH 2/5] removed static margin --- src/components/popover/Popover.style.scss | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/components/popover/Popover.style.scss b/src/components/popover/Popover.style.scss index 6b339b73..f45c885b 100644 --- a/src/components/popover/Popover.style.scss +++ b/src/components/popover/Popover.style.scss @@ -5,8 +5,6 @@ &__content { @include box(false); padding: .5rem; - margin-bottom: .5rem; - margin-top: .5rem; overflow-y: auto; } } \ No newline at end of file From e4a52cd6f2ef4e074a8613a22becffee98a45015 Mon Sep 17 00:00:00 2001 From: nicosammito Date: Sun, 18 Feb 2024 21:25:19 +0100 Subject: [PATCH 3/5] added offset 8 = 0.5rem --- src/components/popover/InternalPopover.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/popover/InternalPopover.tsx b/src/components/popover/InternalPopover.tsx index 9e784e6a..53763620 100644 --- a/src/components/popover/InternalPopover.tsx +++ b/src/components/popover/InternalPopover.tsx @@ -10,7 +10,7 @@ interface InternalPopoverType extends Omit { export const InternalPopover: React.FC = (props) => { - const {children, state, offset = 0, ...args} = props + const {children, state, offset = 8, ...args} = props const popoverRef = React.useRef(null); const {popoverProps} = usePopover({ ...args, From 270ba64ee4cd7d592f61fc17439ea7da002f23ed Mon Sep 17 00:00:00 2001 From: nicosammito Date: Sun, 18 Feb 2024 21:25:45 +0100 Subject: [PATCH 4/5] removed static margin --- src/components/popover/Popover.style.scss | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/components/popover/Popover.style.scss b/src/components/popover/Popover.style.scss index 6b339b73..f45c885b 100644 --- a/src/components/popover/Popover.style.scss +++ b/src/components/popover/Popover.style.scss @@ -5,8 +5,6 @@ &__content { @include box(false); padding: .5rem; - margin-bottom: .5rem; - margin-top: .5rem; overflow-y: auto; } } \ No newline at end of file From 7541025a5a87533e0bf08c96cff480e3dd992c82 Mon Sep 17 00:00:00 2001 From: nicosammito Date: Thu, 29 Feb 2024 22:29:25 +0100 Subject: [PATCH 5/5] fixed #60 --- src/components/popover/InternalPopover.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/components/popover/InternalPopover.tsx b/src/components/popover/InternalPopover.tsx index 53763620..eea8cd50 100644 --- a/src/components/popover/InternalPopover.tsx +++ b/src/components/popover/InternalPopover.tsx @@ -10,11 +10,12 @@ interface InternalPopoverType extends Omit { export const InternalPopover: React.FC = (props) => { - const {children, state, offset = 8, ...args} = props + const {children, state, offset = 8, containerPadding = 24, ...args} = props const popoverRef = React.useRef(null); const {popoverProps} = usePopover({ ...args, offset, + containerPadding, popoverRef }, state);