Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why cycleretry cannot work in QueueScheduler #58

Closed
yxssfxwzy opened this issue Feb 25, 2014 · 2 comments
Closed

why cycleretry cannot work in QueueScheduler #58

yxssfxwzy opened this issue Feb 25, 2014 · 2 comments
Assignees

Comments

@yxssfxwzy
Copy link
Contributor

This project is amazing! But I have a tiny question.

I consider the push function of QueueScheduler should be as follows.

public synchronized void push(Request request, Task task) {
        if (request.getExtra(Request.CYCLE_TRIED_TIMES) != null || urls.add(request)) {
            queue.add(request);
        }
}

Hope to receive your reply! Thanks!

@code4craft
Copy link
Owner

Thanks for report! The reason is I FORGET :(
I add cycleretry as an experimental feature and for RedisScheduler. It seems work well, but I forget to support it in other schedulers.
It will be supported in 0.5.0.

@code4craft code4craft added this to the WebMagic-0.5.0 milestone Feb 25, 2014
@code4craft code4craft self-assigned this Feb 25, 2014
@yxssfxwzy yxssfxwzy reopened this Feb 26, 2014
@yxssfxwzy
Copy link
Contributor Author

Got it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants