Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added my contributions in CONTIBUTORS.md #207

Merged
merged 4 commits into from Dec 14, 2017

Conversation

@rahulkumaran
Copy link
Contributor

commented Dec 14, 2017

Thank you for your contribution. Please provide the details requested below.

ISSUE NUMBER

#201

SHORT DESCRIPTION

Added my name along with the PR's (with embedded links) and mentioned whether they are open/closed/merged

TESTING

No need to test

rahulkumaran added some commits Dec 14, 2017

@rahulkumaran

This comment has been minimized.

Copy link
Contributor Author

commented Dec 14, 2017

@prateekiiest , I've just added my name and the list of PR's I've opened/ closed / merged until today! Please have a look and allow this PR to update the CONTRIBUTORS.md file

@@ -5,7 +5,8 @@
Thanks for all your contributions :heart: :octocat:


[prateekiiest](https://github.com/prateekiiest) : KWOC Mentor
[prateekiiest](https://github.com/prateekiiest) : KWOC Mentor <br>
[Rahul Arulkumaran](https://github.com/rahulkumaran) : KWOC Contributor <br>

This comment has been minimized.

Copy link
@prateekiiest

prateekiiest Dec 14, 2017

Member

Remove your name here 👍

This comment has been minimized.

Copy link
@rahulkumaran

rahulkumaran Dec 14, 2017

Author Contributor

I'll do it right away :)

|[Rahul Arulkumaran](https://github.com/rahulkumaran)| [#88](https://github.com/codeIIEST/Algorithms/pull/88) | CLOSED |
|[Rahul Arulkumaran](https://github.com/rahulkumaran)| [#89](https://github.com/codeIIEST/Algorithms/pull/89) | CLOSED |
|[Rahul Arulkumaran](https://github.com/rahulkumaran)| [#90](https://github.com/codeIIEST/Algorithms/pull/90) | CLOSED |
|[Rahul Arulkumaran](https://github.com/rahulkumaran)| [#93](https://github.com/codeIIEST/Algorithms/pull/93) | CLOSED |

This comment has been minimized.

Copy link
@prateekiiest

prateekiiest Dec 14, 2017

Member

instead of so many names, add the PR links separated by commas, do it only in one field like this

name | PR1, PR2, PR3 | Open, Closed, Merged

This comment has been minimized.

Copy link
@rahulkumaran

rahulkumaran Dec 14, 2017

Author Contributor

SO I'll create 3 rows? 1 each for open, closed and merged! Is that okay? @prateekiiest

@prateekiiest

This comment has been minimized.

Copy link
Member

commented Dec 14, 2017

Looks good 🎆

Thanks for the contribution 🥇

@prateekiiest prateekiiest merged commit f7df730 into codeIIEST:master Dec 14, 2017

4 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
codebeat no reportable quality changes
Details
codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.