Skip to content

Conversation

@ww3637
Copy link
Member

@ww3637 ww3637 commented Aug 1, 2020

No description provided.

@ww3637 ww3637 linked an issue Aug 1, 2020 that may be closed by this pull request
@ww3637 ww3637 requested a review from peterkos August 1, 2020 22:21
@ww3637 ww3637 assigned ww3637 and unassigned ww3637 Aug 1, 2020
@peterkos
Copy link
Contributor

peterkos commented Aug 7, 2020

Current status: discussing in Slack, waiting for final info on contact point for interested codeRIT members (as our site isn't ready yet)

@ww3637 ww3637 self-assigned this Aug 16, 2020
@peterkos
Copy link
Contributor

Thoughts on having it in console vs. in the top of the inspect element tab? Which do y'all typically click on / go to when you're poking around a site?

I personally look in the inspect element first because I'm curious what frameworks certain websites use.

@peterkos peterkos added this to the BrickHack7 milestone Aug 18, 2020
@ww3637
Copy link
Member Author

ww3637 commented Aug 18, 2020

Are you suggesting that it be like text in an element w/ no display like this? At least on Edge, I generally access console via inspect element first & never really felt the need to find a direct shortcut to console.

Honestly, I generally don't look at the console if I ever poke around a site

image

@peterkos
Copy link
Contributor

Let's try it as a comment at the top of the HTML

Copy link
Contributor

@peterkos peterkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in Slack, add it to both the comment and the console and it's good to go!

@ww3637 ww3637 changed the title Basic link to codeRIT added to the console Hidden codeRIT hiring notices added to the BrickHack site Aug 24, 2020
@ww3637 ww3637 requested a review from peterkos August 24, 2020 23:55
Copy link
Contributor

@peterkos peterkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, not sure why this review didn't go through!

Michael and I are talking about adding ASCII art into here; will update you on Slack with it when we figure it out; but overall structure looks good!

As discussed in Slack I'd suggest adding a comment about how the hiring blurb is inserted into the HTML as well as the JS console.

ww3637 and others added 2 commits August 29, 2020 18:51
@ww3637 ww3637 requested a review from peterkos August 29, 2020 22:53
@ww3637 ww3637 merged commit 3eaaa25 into develop Sep 6, 2020
@ww3637 ww3637 deleted the hiring branch September 6, 2020 14:49
peterkos pushed a commit that referenced this pull request Aug 4, 2021
Hidden codeRIT hiring notices added to the BrickHack site
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

codeRIT hiring blurb in the HTML comments / JS console

3 participants