-
Notifications
You must be signed in to change notification settings - Fork 30
Hidden codeRIT hiring notices added to the BrickHack site #939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Current status: discussing in Slack, waiting for final info on contact point for interested codeRIT members (as our site isn't ready yet) |
|
Thoughts on having it in console vs. in the top of the inspect element tab? Which do y'all typically click on / go to when you're poking around a site? I personally look in the inspect element first because I'm curious what frameworks certain websites use. |
|
Let's try it as a comment at the top of the HTML |
peterkos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in Slack, add it to both the comment and the console and it's good to go!
peterkos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, not sure why this review didn't go through!
Michael and I are talking about adding ASCII art into here; will update you on Slack with it when we figure it out; but overall structure looks good!
As discussed in Slack I'd suggest adding a comment about how the hiring blurb is inserted into the HTML as well as the JS console.
Co-authored-by: Peter Kos <pkos91@icloud.com>
Hidden codeRIT hiring notices added to the BrickHack site

No description provided.