Added sponsor info text below email input #945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ww3637
reviewed
Aug 18, 2020
src/preregister.js
Outdated
| <MailchimpInput/> | ||
|
|
||
| <CovidPopover | ||
| <div id="contact"> |
Member
There was a problem hiding this comment.
I would suggest adding 'mobile-hide' to its classes so this doesn't mess with spacing on mobile devices
Right now it has no size-scaling so it looks big on smaller devices & pushes things down (the mobile COVID notice is definitely off-screen for iPhone 5/6/7)
Alternatively I can play around with vertical spacing if you think it's important to have this be visible on mobile
ww3637
previously approved these changes
Aug 18, 2020
Member
|
Approved b/c of high priority but I highly suggest refining for mobile |
Mobile layout handling should be more pragmatic, so that should be refactored before we re-tweak the entire mobile layout to make room for this notice.
Contributor
Author
|
Bumped up the margin around the form: 10px->20px |
ww3637
approved these changes
Aug 18, 2020
cbaudouinjr
requested changes
Aug 18, 2020
Member
cbaudouinjr
left a comment
cbaudouinjr
left a comment
There was a problem hiding this comment.
- Text change does not appear on mobile
Contributor
Author
|
Will be addressed in #947 |
peterkos
added a commit
that referenced
this pull request
Aug 4, 2021
Added sponsor info text below email input on desktop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #942
Adds a contact email for sponsors to get in touch w/ the BH team
Although this doesn't have the centering fixes in #938 it does have higher priority than that PR.
Notes