Skip to content

Min-height for desktop content, changed media-query cutoffs, SASS indentation uses tabs now #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 22, 2020
Merged

Min-height for desktop content, changed media-query cutoffs, SASS indentation uses tabs now #955

merged 10 commits into from
Sep 22, 2020

Conversation

@ww3637
Copy link
Member

@ww3637 ww3637 commented Sep 12, 2020 •
edited
Loading

  • Added min-height for desktop content so the content never get squished with a vertically minimized window
  • Increased desktop media-query cutoff to avoid COVID banner text overflow
  • The one SASS file now uses tab spacing rather than two spaces

@ww3637 ww3637 self-assigned this Sep 12, 2020
@ww3637 ww3637 added the BH7 label Sep 12, 2020
@ww3637 ww3637 linked an issue Sep 12, 2020 that may be closed by this pull request
Add min-height for desktop content, lower desktop-view media query requirement #953
Closed
@ww3637 ww3637 requested a review from peterkos September 12, 2020 23:37
@ww3637 ww3637 linked an issue Sep 19, 2020 that may be closed by this pull request
Fix desktop COVID banner overflowing at certain resolutions #958
Closed
@ww3637 ww3637 changed the title Added min-height for desktop content, adjusted media-query cutoffs Min-height for desktop content, changed media-query cutoffs, SASS indentation uses tabs now Sep 20, 2020
@ww3637 ww3637 linked an issue Sep 20, 2020 that may be closed by this pull request
SASS indentation #927
Closed
peterkos
peterkos requested changes Sep 22, 2020
View reviewed changes
@ww3637 @peterkos
Update src/index.scss
7d4f14c 
Co-authored-by: Peter Kos <pkos91@icloud.com>
@ww3637 ww3637 requested a review from peterkos September 22, 2020 06:54
@peterkos peterkos merged commit 12c8527 into develop Sep 22, 2020
@peterkos peterkos deleted the issue-953 branch September 22, 2020 21:23
peterkos added a commit that referenced this pull request Aug 4, 2021
@peterkos
Merge pull request #955 from codeRIT/issue-953
22788e3 
Min-height for desktop content, changed media-query cutoffs, SASS indentation uses tabs now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterkos peterkos peterkos approved these changes

Assignees

@ww3637 ww3637

Labels

BH7

Projects

None yet

Milestone

No milestone

3 participants

@ww3637 @peterkos