Make Stream Post Title & Text Optional #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR makes the text parameter optional in the CreateAPostInAGivenStream request class, allowing posts to be created with only a title or other content (like files or media) without requiring text content.
- Changed the
textconstructor parameter from required to optional with a null default value - Modified
defaultBody()to conditionally includetextonly when it has a value - Updated the conditional logic to use Laravel's
filled()helper for consistency
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| $body = []; | ||
|
|
||
| if (! empty($this->title)) { | ||
| if (filled($this->title)) { |
There was a problem hiding this comment.
[nitpick] Inconsistent use of conditional checks: filled() is used for title and text, but ! empty() is used for other optional fields like scheduledAt (line 88), labels (line 72), files (line 98), media (line 108), and options (line 118). Consider using filled() consistently for all nullable string and array fields to maintain a uniform code style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.