From 7d5f9c441907263cb0cd1797a53910b95e75547d Mon Sep 17 00:00:00 2001 From: Morgan Roderick Date: Thu, 6 Aug 2026 15:11:02 +0200 Subject: [PATCH] feat: rename magic link sign-in to "Sign in with e-mail" --- e2e/oauth-flow.spec.js | 2 +- src/app/components/login.js | 2 +- src/app/routes/auth.js | 4 ++-- test/features/magic-links.test.js | 3 ++- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/e2e/oauth-flow.spec.js b/e2e/oauth-flow.spec.js index 9c23d24..157bb67 100644 --- a/e2e/oauth-flow.spec.js +++ b/e2e/oauth-flow.spec.js @@ -28,7 +28,7 @@ test("OAuth 2.1 magic link flow", async ({ page, request }) => { await expect(page).toHaveURL(/\/login/); // Click through to the magic link form - await page.getByRole("button", { name: /Send Magic Link/i }).click(); + await page.getByRole("button", { name: /Sign in with e-mail/i }).click(); await expect(page).toHaveURL(/\/login\/magic-link/); // Submit email diff --git a/src/app/components/login.js b/src/app/components/login.js index e66b09a..44819b1 100644 --- a/src/app/components/login.js +++ b/src/app/components/login.js @@ -13,7 +13,7 @@ export const MagicLinkButton = ({ callbackURL } = {}) => html`
`; diff --git a/src/app/routes/auth.js b/src/app/routes/auth.js index d80dd38..f539622 100644 --- a/src/app/routes/auth.js +++ b/src/app/routes/auth.js @@ -43,7 +43,7 @@ function showMagicLinkForm(c) { return c.html( Layout({ - title: "Magic Link Login", + title: "Sign in with e-mail", children: html`
@@ -68,7 +68,7 @@ function showMagicLinkForm(c) { />
diff --git a/test/features/magic-links.test.js b/test/features/magic-links.test.js index cfbb374..1b7ef15 100644 --- a/test/features/magic-links.test.js +++ b/test/features/magic-links.test.js @@ -59,8 +59,9 @@ test("magic links feature tests", async (t) => { t.equal(res.status, 200, "magic link page loads"); const html = await res.text(); - t.match(html, /Magic Link/i, "displays magic link heading"); + t.match(html, /Sign in with e-mail/, "displays e-mail sign-in page"); t.match(html, /email/i, "has email input"); + t.match(html, /Sign in with e-mail/, "shows e-mail sign-in button"); }); t.test("login page shows friendly message for INVALID_TOKEN", async (t) => {