Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor the workshop edit to use the form partial #1155
Right, fairly parrell, except this line so lets make sure. If you change out of the branch to master. And do
And roll down to that line and copy the sha and do
So, if I was a maintainer, I would want to know that the person making this PR had seen that and knew that this code wouldn't change that - this is the only line we can get wrong :-) And because this business knowledge will disappear with the deletion of the file (to all but the most determined reader).
So, and I haven't tried this, but with the change:
Because if we break that we're going to be really unpopular with the most influential people in codebar :) And after a while of hunting you down they'll work out that the [X] isn't actually a mis-loaded image and then you'll be in big trouble.