Stub Flodesk requests #2402
Merged
Stub Flodesk requests #2402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnclmorais
force-pushed
the
stub-flodesk-requests
branch
2 times, most recently
from
c2e0cc7 to
25bf47f
Compare
Addresses the issue by disabling web requests while running tests (something I believe to be a good practice) and stubs requests specifically to Flodesk’s API. Fixes codebar#2322
gnclmorais
force-pushed
the
stub-flodesk-requests
branch
from
25bf47f to
8443d31
Compare
olleolleolle
approved these changes
Nov 28, 2025
Collaborator
olleolleolle
left a comment
olleolleolle
left a comment
There was a problem hiding this comment.
Thank you! Good to have that in place.
|
|
||
| config.before(:each) do | ||
| # Stub all Flodesk API endpoints globally so tests don't make external requests | ||
| # when fabricating members (which trigger Subscription.after_create callback) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issue by disabling web requests while running tests (something I believe to be a good practice) and stubs requests specifically to Flodesk’s API. Fixes #2322