Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method switchTo().alert() should throw NoAlertPresentException #273

Closed
asolntsev opened this issue Jan 17, 2016 · 6 comments
Closed

Method switchTo().alert() should throw NoAlertPresentException #273

asolntsev opened this issue Jan 17, 2016 · 6 comments
Assignees
@asolntsev
Milestone
4.13.0

Comments

@asolntsev
Copy link
Member

since Selenide 3.1, it throws TimeoutException.

Probably the same problem with methods switchTo().window() and switchTo().frame()
@gitsnuit
Copy link

gitsnuit commented Mar 2, 2016

Also applies to confirm()

@asolntsev
Copy link
Member Author

@martybum agree. We must fix it in Selenide 3.4

@gitsnuit
Copy link

gitsnuit commented Nov 8, 2016

@asolntsev any news on this?

@asolntsev
Copy link
Member Author

Hi!
Unfortunately I haven't worked on it meanwhile.
Thanks for the reminder, should do it.

By the way, pull requests are welcomed. :)

Andrei Solntsev

2016-11-08 17:27 GMT+02:00 Martyn notifications@github.com:

@asolntsev https://github.com/asolntsev any news on this?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#273 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AARE3WrC1ib0RdTb1vbHvjuFkvZErLXlks5q8JTWgaJpZM4HGhE0
.

@symonk
Copy link
Contributor

symonk commented Aug 2, 2018

will investigate this one this weekend

tsukakei added a commit to tsukakei/selenide that referenced this issue Aug 4, 2018
@tsukakei
selenide#273 throw NoAlertPresentException, NoSuchWindowException, or…
7e59be1 
… NoSuchFrameException instead of TimeoutException
@tsukakei tsukakei mentioned this issue Aug 4, 2018
Merged
3 tasks
@tsukakei
Copy link
Contributor

tsukakei commented Aug 4, 2018

I opened a new pull request about this issue. Welcome any comments or suggestions!

asolntsev added a commit that referenced this issue Aug 6, 2018
@asolntsev
Merge pull request #774 from tsukakei/feature/throw_no_alert_present_…
816622d 
…exception

#273 throw NoAlertPresentException, NoSuchWindowException, or NoSuchF…
@rosolko rosolko closed this as completed Aug 9, 2018
@asolntsev asolntsev added this to the 4.12.4 milestone Aug 9, 2018
@asolntsev asolntsev self-assigned this Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asolntsev asolntsev

Labels
None yet
Projects
None yet
Milestone
4.13.0
Development

No branches or pull requests
5 participants
@asolntsev @gitsnuit @rosolko @tsukakei @symonk