New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bug with IE and basic auth #369
Conversation
@simple-elf Thanks for the quick fix :-) |
Sorry for commit spam, I'm new on github =) |
@simple-elf also can you add a test-case for it. |
@simple-elf Thank you for the fix. NB! Why do you think that this is "quick fix" Do you think that it's a "dirty temporary solution"? Do you have an idea of f better solution? |
@simple-elf @anilreddy I have merged the fix and released selenide 3.8.1 |
We need to test not only this fix, but all code in IE too, but it's hard to find such service for IE. Maybe SauceLabs? I need to investigate it. |
Test shoul be smth like this
|
+1
Don't you know a good and cheap Windows hosting? |
For running tests in IE we probably can use SauceLabs, it has free VM's for open source projects with IE |
@anilreddy 3.8.1 already in maven |
@simple-elf yeah am already using it. |
Problem mentioned in #366 and highlighted in #320.
So here is quick fix of that. I think if there is empty login parameter we don't need to handling alert for basic auth.