New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding CollectionCondition.texts(List<String>) and CollectionCondition.texts(List<String>) #419

Closed
yashaka opened this Issue Oct 29, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@yashaka
Contributor

yashaka commented Oct 29, 2016

Sometimes "texts data to be asserted for collection" comes as List<String> not String[]

This leads to such ugly code:

headers().shouldHave(exactTexts(listOfTexts.toArray(new String[0])));

The idea is to add additional conditions which can accept List<String> instead of String.../String[]

so code from above becomes:

headers().shouldHave(exactTexts(listOfTexts)));
@asolntsev

This comment has been minimized.

Show comment
Hide comment
@asolntsev

asolntsev Oct 29, 2016

Member

Agree. Let's use Lists!

Member

asolntsev commented Oct 29, 2016

Agree. Let's use Lists!

@asolntsev asolntsev added the feature label Oct 29, 2016

@asolntsev asolntsev added this to the 4.1 milestone Nov 30, 2016

@asolntsev

This comment has been minimized.

Show comment
Hide comment
@asolntsev

asolntsev Nov 30, 2016

Member

@yashaka implemented by @pavelsmolensky in PR #425
Merged to Selenide 4.1

Member

asolntsev commented Nov 30, 2016

@yashaka implemented by @pavelsmolensky in PR #425
Merged to Selenide 4.1

@asolntsev asolntsev closed this Nov 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment