Consider adding CollectionCondition.texts(List<String>) and CollectionCondition.texts(List<String>) #419

Closed
yashaka opened this Issue Oct 29, 2016 · 2 comments

Projects

None yet

2 participants

@yashaka
yashaka commented Oct 29, 2016

Sometimes "texts data to be asserted for collection" comes as List<String> not String[]

This leads to such ugly code:

headers().shouldHave(exactTexts(listOfTexts.toArray(new String[0])));

The idea is to add additional conditions which can accept List<String> instead of String.../String[]

so code from above becomes:

headers().shouldHave(exactTexts(listOfTexts)));
@asolntsev
Member

Agree. Let's use Lists!

@asolntsev asolntsev added the feature label Oct 29, 2016
@asolntsev asolntsev added this to the 4.1 milestone Nov 30, 2016
@asolntsev
Member

@yashaka implemented by @pavelsmolensky in PR #425
Merged to Selenide 4.1

@asolntsev asolntsev closed this Nov 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment