Disable creating .html file, while creating screenshot #359

Merged
merged 1 commit into from Jul 31, 2016

Projects

None yet

2 participants

@BorisOsipov
Contributor

#358 Disable creating .html file, while creating screenshot

@asolntsev
Member

Thanks for the PR!
However, there is one problem. If failed to take screenshot, Selenide returned html (with default settings). Now it does not return html. :(

@BorisOsipov
Contributor

Hi, Andrei!

Yes indeed, now method takeScreenShot doesn't return html.
But it's a rare case when screenshoting fails and we need return smth != null. And I believe end-user should setup its enviroment in these cases, if they want screenshots.
Also, it looks strange: method takeScreenShot() in fact could return path to non-screenshot file.

Nevertheless, if you don't think so, let me know and I change fix.

Thanks,
Boris

@asolntsev asolntsev merged commit 28d87ba into codeborne:master Jul 31, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@asolntsev asolntsev added a commit that referenced this pull request Jul 31, 2016
@asolntsev asolntsev #359 fix code formatting b1b0988
@asolntsev
Member

@BorisOsipov I don't like losing old functionality.
However, it was not well-designed. Error message should show path to both ".html" and ".png" files - see issue 210. So, let's merge current PR as is and implement issue 210.

Thanks for the PR! Merged.

@asolntsev asolntsev added the feature label Jul 31, 2016
@asolntsev asolntsev added this to the 3.8 milestone Jul 31, 2016
@asolntsev asolntsev self-assigned this Jul 31, 2016
@BorisOsipov BorisOsipov added a commit to BorisOsipov/selenide that referenced this pull request Nov 23, 2016
@asolntsev @BorisOsipov asolntsev + BorisOsipov #359 fix code formatting f647242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment