Turn on temporary disabled test for firefox #379

Merged
merged 1 commit into from Sep 19, 2016

Projects

None yet

2 participants

@BorisOsipov
Contributor

Bug http://bit.ly/1JKT4AE has been fixed. Turn on related tests.

@BorisOsipov
Contributor
BorisOsipov commented Aug 22, 2016 edited

Corresponding test failed on Travis CI, but reason as I can see that is for tests used
"�firefox 31.0esr" when bug aren't fixed yet.
On my workstation with Firefox 47.0.1 all tests passed.

@asolntsev asolntsev merged commit e049c9c into codeborne:master Sep 19, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@asolntsev
Member

@BorisOsipov Really? Are you sure? I still cannot run any tests on FireFox browser...

@asolntsev asolntsev added this to the 3.10 milestone Sep 19, 2016
@asolntsev asolntsev added a commit that referenced this pull request Sep 19, 2016
@asolntsev asolntsev #379 ignore test in htmlunit
It fails with the following error:

java.lang.StringIndexOutOfBoundsException: start > length()
	at java.lang.AbstractStringBuilder.replace(AbstractStringBuilder.java:826)
	at java.lang.StringBuilder.replace(StringBuilder.java:262)
	at com.gargoylesoftware.htmlunit.html.DoTypeProcessor.add(DoTypeProcessor.java:136)
	at com.gargoylesoftware.htmlunit.html.DoTypeProcessor.doType(DoTypeProcessor.java:121)
	at com.gargoylesoftware.htmlunit.html.HtmlNumberInput.doType(HtmlNumberInput.java:54)
	at com.gargoylesoftware.htmlunit.html.HtmlElement.type(HtmlElement.java:547)
	at com.gargoylesoftware.htmlunit.html.HtmlElement.type(HtmlElement.java:495)
	at com.gargoylesoftware.htmlunit.html.HtmlElement.type(HtmlElement.java:480)
	at org.openqa.selenium.htmlunit.HtmlUnitKeyboard.sendKeys(HtmlUnitKeyboard.java:88)
	at org.openqa.selenium.htmlunit.HtmlUnitWebElement.sendKeys(HtmlUnitWebElement.java:333)
	at com.codeborne.selenide.commands.SetValue.execute(SetValue.java:42)
264fe19
@asolntsev asolntsev added a commit that referenced this pull request Sep 20, 2016
@asolntsev asolntsev #379 ignore test in phantomjs 1fd2526
@BorisOsipov BorisOsipov added a commit to BorisOsipov/selenide that referenced this pull request Nov 23, 2016
@asolntsev @BorisOsipov asolntsev + BorisOsipov #379 ignore test in htmlunit
It fails with the following error:

java.lang.StringIndexOutOfBoundsException: start > length()
	at java.lang.AbstractStringBuilder.replace(AbstractStringBuilder.java:826)
	at java.lang.StringBuilder.replace(StringBuilder.java:262)
	at com.gargoylesoftware.htmlunit.html.DoTypeProcessor.add(DoTypeProcessor.java:136)
	at com.gargoylesoftware.htmlunit.html.DoTypeProcessor.doType(DoTypeProcessor.java:121)
	at com.gargoylesoftware.htmlunit.html.HtmlNumberInput.doType(HtmlNumberInput.java:54)
	at com.gargoylesoftware.htmlunit.html.HtmlElement.type(HtmlElement.java:547)
	at com.gargoylesoftware.htmlunit.html.HtmlElement.type(HtmlElement.java:495)
	at com.gargoylesoftware.htmlunit.html.HtmlElement.type(HtmlElement.java:480)
	at org.openqa.selenium.htmlunit.HtmlUnitKeyboard.sendKeys(HtmlUnitKeyboard.java:88)
	at org.openqa.selenium.htmlunit.HtmlUnitWebElement.sendKeys(HtmlUnitWebElement.java:333)
	at com.codeborne.selenide.commands.SetValue.execute(SetValue.java:42)
098887e
@BorisOsipov BorisOsipov added a commit to BorisOsipov/selenide that referenced this pull request Nov 23, 2016
@asolntsev @BorisOsipov asolntsev + BorisOsipov #379 ignore test in phantomjs 2d87709
@asolntsev asolntsev added a commit that referenced this pull request Dec 13, 2016
@asolntsev asolntsev #379 simplify code, improve logging 46c3793
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment