New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#243, #365: changed ElementsCollections#find. Test classes - getting collections & elements in different way. Given helpers - html site building. #426

Merged
merged 3 commits into from Jan 5, 2017

Conversation

Projects
None yet
2 participants
@juliaviluhina
Contributor

juliaviluhina commented Nov 9, 2016

#243, #365

  • selenide/ElementsCollection#find changed
  • selenide/impl/CollectionElementByCondition - added (used in ElementsCollection#find)
  • selenide/impl/WebElementSource#checkCondition - changed (used Throwable instead of RuntimeException)
    • it was needed to catch IndexOutOfBounds, which throwed from ElementsCollection code
    • now ElementsCollection#findBy throws ElementNotFound error in case of element is not found

test/java/integration/ScreenshotTest#canTakeScreenshotOfElement() - changed (failed on windows)

Given helpers - html site building. Added:

  • src/test/java/integration/helpers
  • src/test/resources/empty.html

Test classes - getting collections & elements in different way and error messages assertion

  • src/test/java/integration/errormessages - test classes added (MethodCalledOnEntityWithInvalidLocatorFailsOnTest - failing tests)
  • src/test/java/integration/errormessages/package-info.java - description added
  • in test methods it is included:
    • real error message
    • our questions (marked as todo)

@asolntsev asolntsev merged commit f272cf9 into codeborne:master Jan 5, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

asolntsev added a commit that referenced this pull request Jan 5, 2017

asolntsev added a commit that referenced this pull request Jan 6, 2017

asolntsev added a commit that referenced this pull request Jan 6, 2017

asolntsev added a commit that referenced this pull request Jan 6, 2017

asolntsev added a commit that referenced this pull request Jan 6, 2017

asolntsev added a commit that referenced this pull request Jan 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment