New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve byAttribute method for search via css selectors #428

Merged
merged 4 commits into from Nov 30, 2016

Conversation

Projects
None yet
4 participants
@rmarinsky
Contributor

rmarinsky commented Nov 29, 2016

No description provided.

@asolntsev

This comment has been minimized.

Show comment
Hide comment
@asolntsev

asolntsev Nov 29, 2016

Member

@rmarinsky Please fix the failing unit-test.

Member

asolntsev commented Nov 29, 2016

@rmarinsky Please fix the failing unit-test.

@rmarinsky

This comment has been minimized.

Show comment
Hide comment
@rmarinsky

rmarinsky Nov 30, 2016

Contributor

@asolntsev Fixed :)

Contributor

rmarinsky commented Nov 30, 2016

@asolntsev Fixed :)

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 30, 2016

Coverage Status

Changes Unknown when pulling 3f32f35 on rmarinsky:improveByAttribute into ** on codeborne:master**.

coveralls commented Nov 30, 2016

Coverage Status

Changes Unknown when pulling 3f32f35 on rmarinsky:improveByAttribute into ** on codeborne:master**.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Nov 30, 2016

Current coverage is 58.21% (diff: 0.00%)

No coverage report found for master at 9a7a5aa.

Powered by Codecov. Last update 9a7a5aa...3f32f35

codecov-io commented Nov 30, 2016

Current coverage is 58.21% (diff: 0.00%)

No coverage report found for master at 9a7a5aa.

Powered by Codecov. Last update 9a7a5aa...3f32f35

@asolntsev asolntsev merged commit dae942c into codeborne:master Nov 30, 2016

2 of 4 checks passed

codecov/patch 0.00% of diff hit (target 58.21%)
Details
codecov/project 58.21% (-0.05%) compared to 0a7569a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 62.195%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment