New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setValue refactoring #518

Merged
merged 2 commits into from Apr 26, 2017

Conversation

Projects
None yet
4 participants
@AleksanderPopov
Contributor

AleksanderPopov commented Apr 23, 2017

pr for issue #508

@asolntsev

@AleksanderPopov Thank you for the pull request!
Can you please make the following changes?

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 24, 2017

Coverage Status

Coverage increased (+0.1%) to 62.906% when pulling 8c5c9cd on AleksanderPopov:508 into 8ccf2fd on codeborne:master.

coveralls commented Apr 24, 2017

Coverage Status

Coverage increased (+0.1%) to 62.906% when pulling 8c5c9cd on AleksanderPopov:508 into 8ccf2fd on codeborne:master.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Apr 24, 2017

Codecov Report

Merging #518 into master will decrease coverage by 0.08%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #518      +/-   ##
============================================
- Coverage     58.89%   58.81%   -0.09%     
  Complexity      690      690              
============================================
  Files           131      131              
  Lines          2608     2610       +2     
  Branches        264      264              
============================================
- Hits           1536     1535       -1     
- Misses          967      968       +1     
- Partials        105      107       +2
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/codeborne/selenide/Configuration.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...codeborne/selenide/webdriver/WebDriverFactory.java 68.23% <100%> (ø) 34 <1> (ø) ⬇️
...java/com/codeborne/selenide/commands/SetValue.java 88.88% <84.61%> (+4.27%) 9 <4> (+1) ⬆️
...e/selenide/impl/WebDriverThreadLocalContainer.java 77.77% <0%> (-2.09%) 29% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc5cfcb...88289ed. Read the comment docs.

codecov-io commented Apr 24, 2017

Codecov Report

Merging #518 into master will decrease coverage by 0.08%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #518      +/-   ##
============================================
- Coverage     58.89%   58.81%   -0.09%     
  Complexity      690      690              
============================================
  Files           131      131              
  Lines          2608     2610       +2     
  Branches        264      264              
============================================
- Hits           1536     1535       -1     
- Misses          967      968       +1     
- Partials        105      107       +2
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/codeborne/selenide/Configuration.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...codeborne/selenide/webdriver/WebDriverFactory.java 68.23% <100%> (ø) 34 <1> (ø) ⬇️
...java/com/codeborne/selenide/commands/SetValue.java 88.88% <84.61%> (+4.27%) 9 <4> (+1) ⬆️
...e/selenide/impl/WebDriverThreadLocalContainer.java 77.77% <0%> (-2.09%) 29% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc5cfcb...88289ed. Read the comment docs.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 26, 2017

Coverage Status

Coverage decreased (-0.01%) to 62.912% when pulling 51549b2 on AleksanderPopov:508 into cc5cfcb on codeborne:master.

coveralls commented Apr 26, 2017

Coverage Status

Coverage decreased (-0.01%) to 62.912% when pulling 51549b2 on AleksanderPopov:508 into cc5cfcb on codeborne:master.

Alexander Popov and others added some commits Apr 6, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 26, 2017

Coverage Status

Coverage decreased (-0.01%) to 62.912% when pulling 88289ed on AleksanderPopov:508 into cc5cfcb on codeborne:master.

coveralls commented Apr 26, 2017

Coverage Status

Coverage decreased (-0.01%) to 62.912% when pulling 88289ed on AleksanderPopov:508 into cc5cfcb on codeborne:master.

@asolntsev asolntsev merged commit 8463167 into codeborne:master Apr 26, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
coverage/coveralls Coverage decreased (-0.01%) to 62.912%
Details

@asolntsev asolntsev self-assigned this Apr 26, 2017

@asolntsev asolntsev added this to the 4.5 milestone Apr 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment