New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#529 Cannot find capabilities with browserName=ie when grid hub url specified #531

Merged
merged 1 commit into from Jul 3, 2017

Conversation

Projects
None yet
5 participants
@BorisOsipov
Collaborator

BorisOsipov commented May 11, 2017

  • Set correct correct IE browser name in capabilities
  • Add ability to set IE browser through "internet explorer" string

I reproduced issue and verified fix locally with IE 11 and selenium v.3.4.0

@BorisOsipov BorisOsipov reopened this May 11, 2017

#529 Cannot find capabilities with browserName=ie when grid hub url s…
…pecified in -Dremote

- Set correct correct IE browser name
- Add ability to set ie browser through "internet explorer" string
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 11, 2017

Coverage Status

Coverage decreased (-0.02%) to 62.888% when pulling a305cbd on BorisOsipov:529 into 8463167 on codeborne:master.

coveralls commented May 11, 2017

Coverage Status

Coverage decreased (-0.02%) to 62.888% when pulling a305cbd on BorisOsipov:529 into 8463167 on codeborne:master.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io May 11, 2017

Codecov Report

Merging #531 into master will decrease coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #531     +/-   ##
===========================================
- Coverage     58.85%   58.75%   -0.1%     
+ Complexity      691      690      -1     
===========================================
  Files           131      131             
  Lines          2610     2611      +1     
  Branches        264      266      +2     
===========================================
- Hits           1536     1534      -2     
- Misses          968      969      +1     
- Partials        106      108      +2
Impacted Files Coverage Δ Complexity Δ
...codeborne/selenide/webdriver/WebDriverFactory.java 67.64% <0%> (-0.59%) 34 <0> (ø)
...n/java/com/codeborne/selenide/WebDriverRunner.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...e/selenide/impl/WebDriverThreadLocalContainer.java 77.77% <0%> (-0.7%) 29% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8463167...a305cbd. Read the comment docs.

codecov-io commented May 11, 2017

Codecov Report

Merging #531 into master will decrease coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #531     +/-   ##
===========================================
- Coverage     58.85%   58.75%   -0.1%     
+ Complexity      691      690      -1     
===========================================
  Files           131      131             
  Lines          2610     2611      +1     
  Branches        264      266      +2     
===========================================
- Hits           1536     1534      -2     
- Misses          968      969      +1     
- Partials        106      108      +2
Impacted Files Coverage Δ Complexity Δ
...codeborne/selenide/webdriver/WebDriverFactory.java 67.64% <0%> (-0.59%) 34 <0> (ø)
...n/java/com/codeborne/selenide/WebDriverRunner.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...e/selenide/impl/WebDriverThreadLocalContainer.java 77.77% <0%> (-0.7%) 29% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8463167...a305cbd. Read the comment docs.

@simple-elf

This comment has been minimized.

Show comment
Hide comment
@simple-elf

simple-elf Jun 28, 2017

Contributor

I fixed IE with grid by
Configuration.browser = "internet explorer";
But this PR is much better =)

Contributor

simple-elf commented Jun 28, 2017

I fixed IE with grid by
Configuration.browser = "internet explorer";
But this PR is much better =)

@simple-elf

This comment has been minimized.

Show comment
Hide comment
@simple-elf

simple-elf Jun 28, 2017

Contributor

But if we say "ie" to grid - it can't find browser, so we need to pass "internet explorer" to grid capabilities

UPD. Sorry, I thound this
capabilities.setBrowserName(isIE() ? WebDriverRunner.IE_FULL_NAME : browser);

So this PR is legit. There I can vote for this?

Contributor

simple-elf commented Jun 28, 2017

But if we say "ie" to grid - it can't find browser, so we need to pass "internet explorer" to grid capabilities

UPD. Sorry, I thound this
capabilities.setBrowserName(isIE() ? WebDriverRunner.IE_FULL_NAME : browser);

So this PR is legit. There I can vote for this?

@asolntsev asolntsev self-requested a review Jul 3, 2017

@asolntsev asolntsev self-assigned this Jul 3, 2017

@asolntsev asolntsev added this to the 4.6 milestone Jul 3, 2017

@asolntsev

Good!

@asolntsev asolntsev merged commit bc3c15a into codeborne:master Jul 3, 2017

1 of 4 checks passed

codecov/patch 0% of diff hit (target 58.85%)
Details
codecov/project 58.75% (-0.1%) compared to 8463167
Details
coverage/coveralls Coverage decreased (-0.02%) to 62.888%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment