New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix screenshot concurency #595

Merged
merged 6 commits into from Sep 18, 2017

Conversation

Projects
None yet
4 participants
@jane-ryabchenko
Contributor

jane-ryabchenko commented Sep 6, 2017

currentContextScreenshots and allScreenshots were replaced with ThreadLocal containers to make sure that each thread will work with own version of context and won't mess up the other thread's context or screenshots list.

@asolntsev

This comment has been minimized.

Show comment
Hide comment
@asolntsev

asolntsev Sep 11, 2017

Member

@jane-ryabchenko It seems that the red build is just a glitch of Travis CI. The build is green on my private jenkins.

Member

asolntsev commented Sep 11, 2017

@jane-ryabchenko It seems that the red build is just a glitch of Travis CI. The build is green on my private jenkins.

@jane-ryabchenko

This comment has been minimized.

Show comment
Hide comment
@jane-ryabchenko

jane-ryabchenko Sep 11, 2017

Contributor
Contributor

jane-ryabchenko commented Sep 11, 2017

@asolntsev

This comment has been minimized.

Show comment
Hide comment
@asolntsev

asolntsev Sep 11, 2017

Member

@jane-ryabchenko Can you rebase on master branch? We recently fixed this issue with TravisCI reports.

Member

asolntsev commented Sep 11, 2017

@jane-ryabchenko Can you rebase on master branch? We recently fixed this issue with TravisCI reports.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Sep 12, 2017

Coverage Status

Coverage decreased (-0.006%) to 64.367% when pulling e12c4e8 on jane-ryabchenko:fix-screenshot-concurency into d9cf38b on codeborne:master.

coveralls commented Sep 12, 2017

Coverage Status

Coverage decreased (-0.006%) to 64.367% when pulling e12c4e8 on jane-ryabchenko:fix-screenshot-concurency into d9cf38b on codeborne:master.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Sep 12, 2017

Codecov Report

Merging #595 into master will decrease coverage by 0.03%.
The diff coverage is 90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #595      +/-   ##
============================================
- Coverage      60.4%   60.36%   -0.04%     
+ Complexity      725      724       -1     
============================================
  Files           134      134              
  Lines          2644     2652       +8     
  Branches        267      268       +1     
============================================
+ Hits           1597     1601       +4     
- Misses          942      945       +3     
- Partials        105      106       +1
Impacted Files Coverage Δ Complexity Δ
.../codeborne/selenide/impl/ScreenShotLaboratory.java 54.49% <90%> (+0.96%) 34 <8> (ø) ⬇️
...e/selenide/impl/WebDriverThreadLocalContainer.java 77.93% <0%> (-1.38%) 30% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9cf38b...e12c4e8. Read the comment docs.

codecov-io commented Sep 12, 2017

Codecov Report

Merging #595 into master will decrease coverage by 0.03%.
The diff coverage is 90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #595      +/-   ##
============================================
- Coverage      60.4%   60.36%   -0.04%     
+ Complexity      725      724       -1     
============================================
  Files           134      134              
  Lines          2644     2652       +8     
  Branches        267      268       +1     
============================================
+ Hits           1597     1601       +4     
- Misses          942      945       +3     
- Partials        105      106       +1
Impacted Files Coverage Δ Complexity Δ
.../codeborne/selenide/impl/ScreenShotLaboratory.java 54.49% <90%> (+0.96%) 34 <8> (ø) ⬇️
...e/selenide/impl/WebDriverThreadLocalContainer.java 77.93% <0%> (-1.38%) 30% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9cf38b...e12c4e8. Read the comment docs.

@jane-ryabchenko

This comment has been minimized.

Show comment
Hide comment
@jane-ryabchenko

jane-ryabchenko Sep 12, 2017

Contributor

@asolntsev looks like there is some flakiness in tests. I don't see the way how my changes in ScreenShotLaboratory could have affected WebDriverThreadLocalContainer coverage.

Multithread tests are know for their flakiness though.

Contributor

jane-ryabchenko commented Sep 12, 2017

@asolntsev looks like there is some flakiness in tests. I don't see the way how my changes in ScreenShotLaboratory could have affected WebDriverThreadLocalContainer coverage.

Multithread tests are know for their flakiness though.

@asolntsev asolntsev self-requested a review Sep 18, 2017

@asolntsev asolntsev self-assigned this Sep 18, 2017

@asolntsev asolntsev added this to the 4.7 milestone Sep 18, 2017

@asolntsev asolntsev merged commit 5f87f3f into codeborne:master Sep 18, 2017

3 of 4 checks passed

coverage/coveralls Coverage decreased (-0.006%) to 64.367%
Details
codecov/patch 90% of diff hit (target 60.4%)
Details
codecov/project Absolute coverage decreased by -0.03% but relative coverage increased by +29.59% compared to d9cf38b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@asolntsev

This comment has been minimized.

Show comment
Hide comment
@asolntsev

asolntsev Sep 18, 2017

Member

@jane-ryabchenko Thank you! Merged. Sorry for the long delay.

Member

asolntsev commented Sep 18, 2017

@jane-ryabchenko Thank you! Merged. Sorry for the long delay.

@jane-ryabchenko jane-ryabchenko deleted the jane-ryabchenko:fix-screenshot-concurency branch Sep 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment