New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SergeyPirogov Driver manager #610

Merged
merged 6 commits into from Sep 28, 2017

Conversation

Projects
None yet
4 participants
@BorisOsipov
Collaborator

BorisOsipov commented Sep 27, 2017

Proposed changes

The second attempt to integrate automatic driver manager with Selenide.

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

sepi and others added some commits Feb 15, 2017

automatic driver manager added
(cherry picked from commit f99b354)
automatic driver manager test added
(cherry picked from commit 9f4c37a)
- Update webdrivermanager version.
- Don't use webdrivermanager when grid will be used.

Add option to disable WebDriverManager integration.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Sep 27, 2017

Coverage Status

Coverage decreased (-0.5%) to 64.021% when pulling a16ec9c on wd_manager into f24d0f5 on master.

coveralls commented Sep 27, 2017

Coverage Status

Coverage decreased (-0.5%) to 64.021% when pulling a16ec9c on wd_manager into f24d0f5 on master.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Sep 27, 2017

Codecov Report

Merging #610 into master will decrease coverage by 0.58%.
The diff coverage is 4.16%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #610      +/-   ##
============================================
- Coverage     60.93%   60.34%   -0.59%     
+ Complexity      759      758       -1     
============================================
  Files           147      148       +1     
  Lines          2698     2721      +23     
  Branches        257      263       +6     
============================================
- Hits           1644     1642       -2     
- Misses          956      980      +24     
- Partials         98       99       +1
Impacted Files Coverage Δ Complexity Δ
...rne/selenide/webdriver/WebDriverBinaryManager.java 0% <0%> (ø) 0 <0> (?)
...codeborne/selenide/webdriver/WebDriverFactory.java 83.33% <0%> (-3.21%) 13 <0> (ø)
...ain/java/com/codeborne/selenide/Configuration.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...orne/selenide/webdriver/AbstractDriverFactory.java 69.04% <100%> (ø) 10 <1> (ø) ⬇️
...e/selenide/impl/WebDriverThreadLocalContainer.java 76.55% <0%> (-1.38%) 29% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f24d0f5...a16ec9c. Read the comment docs.

codecov-io commented Sep 27, 2017

Codecov Report

Merging #610 into master will decrease coverage by 0.58%.
The diff coverage is 4.16%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #610      +/-   ##
============================================
- Coverage     60.93%   60.34%   -0.59%     
+ Complexity      759      758       -1     
============================================
  Files           147      148       +1     
  Lines          2698     2721      +23     
  Branches        257      263       +6     
============================================
- Hits           1644     1642       -2     
- Misses          956      980      +24     
- Partials         98       99       +1
Impacted Files Coverage Δ Complexity Δ
...rne/selenide/webdriver/WebDriverBinaryManager.java 0% <0%> (ø) 0 <0> (?)
...codeborne/selenide/webdriver/WebDriverFactory.java 83.33% <0%> (-3.21%) 13 <0> (ø)
...ain/java/com/codeborne/selenide/Configuration.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...orne/selenide/webdriver/AbstractDriverFactory.java 69.04% <100%> (ø) 10 <1> (ø) ⬇️
...e/selenide/impl/WebDriverThreadLocalContainer.java 76.55% <0%> (-1.38%) 29% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f24d0f5...a16ec9c. Read the comment docs.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Sep 27, 2017

Coverage Status

Coverage decreased (-0.6%) to 63.984% when pulling a16ec9c on wd_manager into f24d0f5 on master.

coveralls commented Sep 27, 2017

Coverage Status

Coverage decreased (-0.6%) to 63.984% when pulling a16ec9c on wd_manager into f24d0f5 on master.

@asolntsev asolntsev self-requested a review Sep 28, 2017

@asolntsev asolntsev added this to the 4.7 milestone Sep 28, 2017

@asolntsev asolntsev added the feature label Sep 28, 2017

@asolntsev asolntsev merged commit f9a3101 into master Sep 28, 2017

1 of 4 checks passed

codecov/patch 4.16% of diff hit (target 60.93%)
Details
codecov/project 60.34% (-0.59%) compared to f24d0f5
Details
coverage/coveralls Coverage decreased (-0.6%) to 63.984%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@asolntsev asolntsev deleted the wd_manager branch Sep 28, 2017

asolntsev added a commit that referenced this pull request Sep 28, 2017

#610 code cleanup
* removed BinaryDriverManagerTest because it doesn't do anything more than other tests

@asolntsev asolntsev referenced this pull request Sep 28, 2017

Closed

Driver manager #475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment