New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the project to selenium 3.6.0 #611

Merged
merged 4 commits into from Oct 7, 2017

Conversation

Projects
None yet
4 participants
@ostap-oleksyn
Contributor

ostap-oleksyn commented Oct 1, 2017

Proposed changes

  1. Updated project to use selenium 3.6.0. In this version the htmlunit dependency was removed from selenium-java. I removed the transitive property from htmlunit in order for the project to compile(I'm really not sure if this is the right way to do it, as I haven't worked with gradle before).
  2. Since version 3.6.0 the WebDriver constructor that accepts Capabilities object is deprecated and will be removed in the future. The recommended way of creating the webdriver is using browser specific options(e.g. FirefoxOptions, ChromeOptions etc.). I replaced the Capabilities with browser specific option classes where possible.
  3. Replaced the deprecated Locatable interface with recommended org.openqa.selenium.interactions.internal.Locatable
  4. Fixed EdgeDriverFactory. For some reason it was creating a InternetExplorerDriver instead of EdgeDriver.
  5. Removed killBrowser() from WebDriverThreadLocalContainer. The Killable interface is removed from selenium 3.6. Not really sure what this method did before, as the Killable interface wasn't implemented by any class.
  6. Since version 3.6 there is a possibility to start chrome and firefox in a headless mode using browser options(which makes htmlunit kinda obsolete). I added headless property to Configuration class to be able to use that in selenide.
  7. Fixed some tests accordingly with he new changes.

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • [-] I have added tests that prove my fix is effective or that my feature works(The only feature that I added is the headless configuration property. Not really sure how to test it.)
  • I have added necessary documentation (if appropriate)

@ostap-oleksyn ostap-oleksyn changed the title from Updated the project to selenium 3.6.0 to Update the project to selenium 3.6.0 Oct 1, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 1, 2017

Coverage Status

Coverage increased (+0.02%) to 64.317% when pulling c632ff2 on ostap-oleksyn:selenium-3.6 into 1d448ef on codeborne:master.

coveralls commented Oct 1, 2017

Coverage Status

Coverage increased (+0.02%) to 64.317% when pulling c632ff2 on ostap-oleksyn:selenium-3.6 into 1d448ef on codeborne:master.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 1, 2017

Codecov Report

Merging #611 into master will decrease coverage by 0.16%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #611      +/-   ##
============================================
- Coverage     60.66%   60.49%   -0.17%     
+ Complexity      766      763       -3     
============================================
  Files           148      148              
  Lines          2728     2724       -4     
  Branches        264      266       +2     
============================================
- Hits           1655     1648       -7     
- Misses          971      972       +1     
- Partials        102      104       +2
Impacted Files Coverage Δ Complexity Δ
...odeborne/selenide/webdriver/EdgeDriverFactory.java 28.57% <0%> (-11.43%) 2 <0> (ø)
...ain/java/com/codeborne/selenide/Configuration.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...enide/webdriver/InternetExplorerDriverFactory.java 33.33% <0%> (-6.67%) 2 <0> (ø)
...ne/selenide/webdriver/MarionetteDriverFactory.java 33.33% <0%> (ø) 2 <0> (ø) ⬇️
...eborne/selenide/webdriver/ChromeDriverFactory.java 84.61% <100%> (+8.75%) 8 <4> (ø) ⬇️
...e/selenide/impl/WebDriverThreadLocalContainer.java 79.71% <100%> (-0.98%) 30 <0> (-2)
...orne/selenide/webdriver/AbstractDriverFactory.java 69.04% <100%> (ø) 10 <5> (ø) ⬇️
...borne/selenide/webdriver/FirefoxDriverFactory.java 84.84% <90%> (+0.97%) 9 <6> (ø) ⬇️
...rne/selenide/webdriver/WebDriverBinaryManager.java 20% <0%> (-13.34%) 4% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b82a1c...e2b6820. Read the comment docs.

codecov-io commented Oct 1, 2017

Codecov Report

Merging #611 into master will decrease coverage by 0.16%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #611      +/-   ##
============================================
- Coverage     60.66%   60.49%   -0.17%     
+ Complexity      766      763       -3     
============================================
  Files           148      148              
  Lines          2728     2724       -4     
  Branches        264      266       +2     
============================================
- Hits           1655     1648       -7     
- Misses          971      972       +1     
- Partials        102      104       +2
Impacted Files Coverage Δ Complexity Δ
...odeborne/selenide/webdriver/EdgeDriverFactory.java 28.57% <0%> (-11.43%) 2 <0> (ø)
...ain/java/com/codeborne/selenide/Configuration.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...enide/webdriver/InternetExplorerDriverFactory.java 33.33% <0%> (-6.67%) 2 <0> (ø)
...ne/selenide/webdriver/MarionetteDriverFactory.java 33.33% <0%> (ø) 2 <0> (ø) ⬇️
...eborne/selenide/webdriver/ChromeDriverFactory.java 84.61% <100%> (+8.75%) 8 <4> (ø) ⬇️
...e/selenide/impl/WebDriverThreadLocalContainer.java 79.71% <100%> (-0.98%) 30 <0> (-2)
...orne/selenide/webdriver/AbstractDriverFactory.java 69.04% <100%> (ø) 10 <5> (ø) ⬇️
...borne/selenide/webdriver/FirefoxDriverFactory.java 84.84% <90%> (+0.97%) 9 <6> (ø) ⬇️
...rne/selenide/webdriver/WebDriverBinaryManager.java 20% <0%> (-13.34%) 4% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b82a1c...e2b6820. Read the comment docs.

@asolntsev asolntsev merged commit 0f2e450 into codeborne:master Oct 7, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@asolntsev

This comment has been minimized.

Show comment
Hide comment
@asolntsev

asolntsev Oct 7, 2017

Member

@ostap-oleksyn Thank you!

Next time please make independent changes in a separate pull request (like headless mode in this case). Small PRs are easier to review and merge.

Member

asolntsev commented Oct 7, 2017

@ostap-oleksyn Thank you!

Next time please make independent changes in a separate pull request (like headless mode in this case). Small PRs are easier to review and merge.

@ostap-oleksyn ostap-oleksyn deleted the ostap-oleksyn:selenium-3.6 branch Oct 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment