New theme based on Tango Dark #26

Closed
wants to merge 3 commits into
from

Projects

None yet

2 participants

@randomekek

There are a few changes, but it is quite similar to tango dark. Main difference is removing use of bold font, which doesn't quite work with many monospaced fonts. In addition some colors have been changed. Hope you like it.

@codebrainz
Owner

I'd rather not work around broken fonts by having different versions of the themes for each (been there, done that :). You can use a fonts.conf file if you would like to disable fake "emboldening" that causes alignment issues in Geany and other programs.

As for the colour changes, if you have a good reason for the changes (ie. can explain a reason), I think we could just update Tango Dark as long as it doesn't change too much. I don't like the idea of having so similar themes together like 'tango-dark-no-bold.conf', 'tango-dark-yellow-comments.conf', 'tango-dark-italic-tags.conf', etc, when users can easily make these minor tweaks according to their specific taste locally in their .conf files. I hope that makes sense.

Thanks.

@randomekek

Hey, the color changes make it much more pastel and greyer than the original. I guess the judgement is up to you - if it is sufficiently different and looks good enough, we can rename it to something else.

after
before

@codebrainz
Owner

I think they're sufficiently different. If you want to rename it and maybe just leave a note in the comment at the top that it's "inspired" by the tango-dark theme. If I'm not mistaken, "Tango" refers to a specific palette of colours so I think it would be best, agree?

@randomekek

Done 😄

@codebrainz
Owner

Cool, will get around to testing and merging sometime this week, thanks.

@codebrainz
Owner

Alright, so instead of "this week" more like "next year", but I added the theme in 96f5946. Thanks

@codebrainz codebrainz closed this Mar 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment