Couple of points I noticed. #6

Open
elextr opened this Issue Oct 16, 2012 · 1 comment

Projects

None yet

2 participants

@elextr
elextr commented Oct 16, 2012

Couple of points I noticed, wasn't by any means a real review.

  1. some of the keybindings clash with standard ones, ++e and t at least, didn't check all the rest.
  2. in zen_controller_init_python() the variable resident_pylib is static so its only ever initialised to NULL once, not sure if thats part of your commented intermittent crash on subsequent calls
  3. even if the python lib isn't found you fall through to try to initialise anyway, that would probably be a crash.
@codebrainz
Owner

That's all you found? :)

I haven't even really touched this since last year, so not too bad :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment