CI is broken #13

Closed
Overbryd opened this Issue Jul 1, 2011 · 6 comments

Comments

Projects
None yet
2 participants
Contributor

Overbryd commented Jul 1, 2011

The build is broken, but it wasn't me™

Build Update for codebrawl/codebrawl
--------------------------------------------------------

Build : #33

Duration : 2 minutes and 41 seconds
Commit : 37136247 (open_contests)
Author : Overbryd
Message : Featured contests now appear on top, no visual distinction yet [Closes #9]

Status : Failed

View the changeset : https://github.com/codebrawl/codebrawl/compare/2897ab6...3713624

View the full build log and details : http://travis-ci.org/codebrawl/codebrawl/builds/36320
Contributor

jeffkreeftmeijer commented Jul 4, 2011

The problem is that it doesn't have a javascript Runtime (Codebrawl uses Node.js, which is not installed on Travis). We need to add a "ci"-env for Travis that uses therubyracer or something like that. I'll assign this one to myself and I'll post updates here.

Thanks for reporting, Lukas. :)

@ghost ghost assigned jeffkreeftmeijer Jul 4, 2011

Contributor

jeffkreeftmeijer commented Jul 4, 2011

We're having some trouble with Contest#(starting|voting|finishing)_on. They work correctly on the production server (UTC), but not on my box, or on Travis (both CEST). I'm out of ideas. @Overbryd does it work on your machine? :)

Contributor

Overbryd commented Jul 5, 2011

Maybe you could use the timezine aware Time.current?

Contributor

jeffkreeftmeijer commented Jul 5, 2011

I don't think it's that, it's going wrong in closing_on.to_time.utc + 14.hours, which returns 12:00 instead of 14:00 (where closing_on is a date).

Contributor

jeffkreeftmeijer commented Jul 9, 2011

The CI is passing now (http://travis-ci.org/#!/codebrawl/codebrawl). Thanks for reporting! :)

Contributor

Overbryd commented Jul 9, 2011

Great job :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment