Skip to content

A user should be able to update her e-mail address #32

Open
jeffkreeftmeijer opened this Issue Sep 16, 2011 · 5 comments

3 participants

@jeffkreeftmeijer

Lots of users don't have Gravatars right now, that's because we don't get e-mail addresses from the Github API for some (I'm not sure, but I think that's some kind of option you can set). A user should be able to fix that by setting his e-mail address, and we'll only use it to create the Gravatar hash.

I think it would be cool if the user can update her email address from the profile page (http://codebrawl.com/users/jeffkreeftmeijer is mine) using some kind of in-place-editing thing. :)

@inkel
Codebrawl member
inkel commented Sep 16, 2011

GitHub does provides the Gravatar URL used by the user via their API:

>> curl -i https://api.github.com/users/inkel
HTTP/1.1 200 OK
Server: nginx/1.0.4
Date: Fri, 16 Sep 2011 12:53:35 GMT
Content-Type: application/json
Connection: keep-alive
Status: 200 OK
X-RateLimit-Limit: 5000
X-RateLimit-Remaining: 4999
Link: <repos>; rel="repos", <watched>; rel="watching", <followers>; rel="followers", <following>; rel="following"
Content-Length: 667

{
  "following": 20,
  "type": "User",
  "bio": null,
  "blog": "http://about.me/inkel",
  "email": "",
  "login": "inkel",
  "created_at": "2009-07-24T19:01:07Z",
  "public_gists": 6,
  "public_repos": 30,
  "html_url": "https://github.com/inkel",
  "gravatar_id": "69ada3a32ca6d8dd797202d230cc0190",
  "name": "Leandro López",
  "company": null,
  "avatar_url": "https://secure.gravatar.com/avatar/69ada3a32ca6d8dd797202d230cc0190?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
  "location": "Buenos Aires, Argentina",
  "hireable": false,
  "id": 108421,
  "followers": 10,
  "url": "https://api.github.com/users/inkel"
}

Why not use that?

@jeffkreeftmeijer

We do, but for some users this value is empty (this is @rstacruz, for example):

➜  ~  curl -i https://api.github.com/users/rstacruz
HTTP/1.1 200 OK
Server: nginx/1.0.4
Date: Fri, 16 Sep 2011 13:02:31 GMT
Content-Type: application/json
Connection: keep-alive
Status: 200 OK
X-RateLimit-Limit: 5000
X-RateLimit-Remaining: 4999
Link: <repos>; rel="repos", <watched>; rel="watching", <followers>; rel="followers", <following>; rel="following"
Content-Length: 745

{
  "following": 6,
  "type": "User",
  "bio": "Designer, developer, entrepreneur, hacker, enthusiast of all things interesting.",
  "blog": "ricostacruz.com",
  "email": null,
  "login": "rstacruz",
  "created_at": "2009-04-16T09:46:24Z",
  "public_gists": 22,
  "public_repos": 59,
  "html_url": "https://github.com/rstacruz",
  "gravatar_id": "f8ec7f90daf8b1defb8e318d663c0f17",
  "name": "Rico Sta. Cruz",
  "company": null,
  "avatar_url": "https://secure.gravatar.com/avatar/f8ec7f90daf8b1defb8e318d663c0f17?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
  "location": "Manila, Philippines",
  "hireable": false,
  "id": 74385,
  "followers": 56,
  "url": "https://api.github.com/users/rstacruz"
}

I prefer not using the gravatar_id Github passes along and creating it myself (from the email address), but it's a good idea to store that too, as a fallback. :)

@inkel
Codebrawl member
inkel commented Sep 16, 2011

I understand, but for instance, in my case, the avatar_url is present but it is not displayed in Codebrawl :S

@jeffkreeftmeijer

We don't store anything but the email field right now, which we use to calculate the gravatar ID ourselves. We don't store Github's gravatar_id field, but I think we should to have a nice fallback for when the user doesn't have an email address. I opened #33 for that and I suggest we do that one first and put this one on hold for now. :)

@rstacruz

Thank you for debugging why I don't have an avatar there—I've always wondered about this myself!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.