Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support AWS CDK v2 #7

Open
therk opened this issue Feb 18, 2022 · 4 comments · Fixed by adrian-goe/nx-plugins#1 · May be fixed by #8
Open

Support AWS CDK v2 #7

therk opened this issue Feb 18, 2022 · 4 comments · Fixed by adrian-goe/nx-plugins#1 · May be fixed by #8

Comments

@therk
Copy link

therk commented Feb 18, 2022

Per https://docs.aws.amazon.com/cdk/v1/guide/home.html, the support for CDK v1 is until June 1, 2022.
Best to generate CDK v2 project per https://docs.aws.amazon.com/cdk/v2/guide/getting_started.html
therk added a commit to efacity/nx-plugins that referenced this issue Feb 18, 2022
@therk
feat: Support AWS CDK v2
388379f 
# Description

Support AWS CDK v2

Per https://docs.aws.amazon.com/cdk/v1/guide/home.html,
the support for CDK v1 is until June 1, 2022.
Best to generate CDK v2 project
Example: https://docs.aws.amazon.com/cdk/v2/guide/getting_started.html

# PR Checklist

- [X] Migrations have been added if necessary
- [X] Unit tests have been added or updated if necessary
- [X] e2e tests have been added or updated if necessary
- [X] Changelog has been updated if necessary
- [X] Documentation has been updated if necessary

# Issue

Resolves codebrewlab#7
@therk therk linked a pull request Feb 18, 2022 that will close this issue
Open
5 tasks
@tienne
Copy link
Member

tienne commented Feb 21, 2022

First of all, thank you for your participation in the issue and PR.
I just started reviewing the PR you left.

jessecollier pushed a commit to jessecollier/nx-plugins that referenced this issue Mar 28, 2022
@therk @jessecollier
feat: Support AWS CDK v2
8f7f58d 
# Description

Support AWS CDK v2

Per https://docs.aws.amazon.com/cdk/v1/guide/home.html,
the support for CDK v1 is until June 1, 2022.
Best to generate CDK v2 project
Example: https://docs.aws.amazon.com/cdk/v2/guide/getting_started.html

# PR Checklist

- [X] Migrations have been added if necessary
- [X] Unit tests have been added or updated if necessary
- [X] e2e tests have been added or updated if necessary
- [X] Changelog has been updated if necessary
- [X] Documentation has been updated if necessary

# Issue

Resolves codebrewlab#7
@gabrielrezzonico
Copy link

Hi! Any progress with the PR @tienne?

@embedify
Copy link

embedify commented Jun 6, 2022

Just want to start by saying thankyou for providing this plugin, saves us a lot of time.

With AWS CDK V1 now in maintenance mode, it would be great to understand the timeline for this pull request being accepted or equivalent support for CDK V2 making its way into this plugin?

@adrian-goe adrian-goe mentioned this issue Jun 28, 2022
Merged
10 tasks
@picosam
Copy link

picosam commented Oct 12, 2022

Hello, is this repository still maintained?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Support AWS CDK v2 adrian-goe/nx-plugins
feat: Support AWS CDK v2 efacity/nx-plugins
5 participants
@therk @gabrielrezzonico @tienne @picosam @embedify