New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove repetitive code. #824

Closed
distalx opened this Issue Apr 16, 2018 · 0 comments

Comments

Projects
None yet
3 participants
@distalx
Copy link
Collaborator

distalx commented Apr 16, 2018

In codebase, several times we are using Meteor.loginWithSlack(options);. it can be replace with a continue-popup. this

For example Here, in .clone-hangout event helper we are checking that if user is not logged in then display a sweetAlert and ask them to log in.

That could be very roughly :

<button class="{{#if currentUser}} clone-hangout {{else}} continue-popup {{/if}}"> 
   clone-hangout
</button>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment