New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll page to top of window when it is rendered #640

Merged
merged 1 commit into from Oct 6, 2017

Conversation

Projects
None yet
3 participants
@railsstudent
Collaborator

railsstudent commented Oct 5, 2017

Fixes #595.

I add the scroll top logic in OnRendered template method of about faq and private policy pages.
When the page is first rendered, $(window).scrollTop() function is invoked to obtain the scrollTop value. If the value is greater than 0, scrollTop is set to 0 to force the page to move to (0,0) of the browser window.

@distalx distalx self-requested a review Oct 6, 2017

@distalx

distalx approved these changes Oct 6, 2017

Looks good to me, thanks a lot @railsstudent

@railsstudent

This comment has been minimized.

Show comment
Hide comment
@railsstudent

railsstudent Oct 6, 2017

Collaborator

@distalx Welcome. I have never written MeteorJS until 2 days ago.

Collaborator

railsstudent commented Oct 6, 2017

@distalx Welcome. I have never written MeteorJS until 2 days ago.

@lpatmo

This comment has been minimized.

Show comment
Hide comment
@lpatmo
Member

lpatmo commented Oct 6, 2017

Thanks @railsstudent!

@lpatmo lpatmo merged commit 82e3a36 into codebuddies:staging Oct 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment