New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 597 study group status #657

Merged
merged 21 commits into from Oct 14, 2017

Conversation

Projects
None yet
3 participants
@railsstudent
Collaborator

railsstudent commented Oct 12, 2017

Fixes #597 .

This PR makes two changes in single study group.
In the sidebar, Online Members section is created to display members that are currently online.
In Members tab, members can input their current status and display it in the member table below. Furthermore, latest status retains in textarea to save typing in case the text demands little change
members_nonownermode
members_ownermode

@lpatmo lpatmo added the In Review label Oct 12, 2017

@lpatmo

lpatmo approved these changes Oct 13, 2017

Great work, @railsstudent! Thanks for taking into account the suggestion of making the placeholder default to the current status (if the current status exists). And the "online members" implementation is brilliant.

One other thing I can think of is we may want to display status_CreatedAt as an italicized text like Friday, November 2nd after the status message similar to what we shown on the Profile page with learnings... but that could be its own issue.

@distalx or @sergeant-q and other reviewers -- any thoughts?

@distalx

Thanks for the PR! Here are some suggestions I hope you'll find helpful.

Show outdated Hide outdated server/members/method.js
Show outdated Hide outdated server/members/method.js
Show outdated Hide outdated server/members/method.js
Show outdated Hide outdated client/templates/study_groups/study_group_online_members.js
@railsstudent

This comment has been minimized.

Show comment
Hide comment
@railsstudent

railsstudent Oct 14, 2017

Collaborator

@distalx Please kindly review

Collaborator

railsstudent commented Oct 14, 2017

@distalx Please kindly review

@distalx

This comment has been minimized.

Show comment
Hide comment
@distalx

distalx Oct 14, 2017

Collaborator

Looks good to me, thanks a lot @railsstudent .

Collaborator

distalx commented Oct 14, 2017

Looks good to me, thanks a lot @railsstudent .

@distalx distalx merged commit bc58897 into codebuddies:staging Oct 14, 2017

@lpatmo lpatmo added the closed label Oct 14, 2017

@lpatmo lpatmo removed the In Review label Oct 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment