New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 654 navbar reorganization #658

Merged
merged 8 commits into from Oct 14, 2017

Conversation

Projects
None yet
2 participants
@railsstudent
Collaborator

railsstudent commented Oct 14, 2017

Fixes #654

Group About and FAQ in Community dropdown menu.
The dropdown menu is consisted of github, slack, blog and open collaborative menu items.
Each menu item has a font-awesome with a menu text to its right
navbar

@lpatmo lpatmo added the In Review label Oct 14, 2017

@lpatmo

This comment has been minimized.

Show comment
Hide comment
@lpatmo

lpatmo Oct 14, 2017

Member

Thank you so much, @railsstudent!!

Could you make two small edits?

  1. Remove the "Github" and "Slack" links from the "My Profile" tab that a user can click on when they're logged in
  2. Let's remove the {{#unless currentUser}} wrapper, so that the "Community" tab shows up even after a user is logged in.

Thank you!

Member

lpatmo commented Oct 14, 2017

Thank you so much, @railsstudent!!

Could you make two small edits?

  1. Remove the "Github" and "Slack" links from the "My Profile" tab that a user can click on when they're logged in
  2. Let's remove the {{#unless currentUser}} wrapper, so that the "Community" tab shows up even after a user is logged in.

Thank you!

Fixes 654. Remove github and slack link from user menu
Login menu can also see community link
@railsstudent

This comment has been minimized.

Show comment
Hide comment
@railsstudent

railsstudent Oct 14, 2017

Collaborator

usermenua9649/31576441-7de6af38-b12d-11e7-805e-bbfb06350275.png)

@lpatmo Files changed. Please check

Collaborator

railsstudent commented Oct 14, 2017

usermenua9649/31576441-7de6af38-b12d-11e7-805e-bbfb06350275.png)

@lpatmo Files changed. Please check

@lpatmo

lpatmo approved these changes Oct 14, 2017

Excellent. Thank you!

@lpatmo lpatmo merged commit a88fb05 into codebuddies:staging Oct 14, 2017

@lpatmo lpatmo added closed and removed In Review labels Oct 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment